Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the tests are too basic (a = [0, 1, 2, 3], a = [1, 1, 1, 1]) which causes some wrong solutions to pass.
For example, it's intended that
a
gets read from, but if one peeks at the expected result, they can avoid reading altogether by writingout[_thread_index_]
= thread_index.To try and improve the first 3 tests, I used a numpy random integer generator, populating
a
with values 0-9.If this is a good proposal and is accepted, I would be happy to update the other tests.
Thanks for making a great intro to GPU programming :)