Cpp Core Check #627

srz-zumix · 2021-11-09T02:14:27Z

C++ Core Guidelines checkers

C26400: Do not assign the result of an allocation or a function call with an owner return value to a raw pointer, use owner instead (i.11).
C26401: Do not delete a raw pointer that is not an owner (i.11).
C26403: Reset or explicitly delete an owner pointer 'xxx' (r.3).
C26405: Do not assign to an owner which may be in valid state (r.3).
- 26400,26403,26405 は RAII で解放を保証できるものは修正
- それ以外は除外
C26409: Avoid calling new and delete explicitly, use std::make_unique instead (r.11).
- C++03 対応のため対応が面倒なので対応しない
C26426: Global initializer calls a non-constexpr function 'XXX' (i.22).
- 対応しないので除外
C26429: Symbol 'xxx' is never tested for nullness, it can be marked as not_null (f.23).
- 許容するので警告は除外
C26432: If you define or delete any default operation in the type 'class XXX', define or delete them all (c.21).
- メンドクサイので対応しない
C26435: Function 'XXX' should specify exactly one of 'virtual', 'override', or 'final' (c.128).
- override がないころは virtual は override してますよという意図を示すのに使っていた
- IUTEST_CXX_OVERRIDE マクロでその意図は示すことは可能だが変えることにメリットを感じないので除外する
C26434: Function 'YYY::XXX' hides a non-virtual function 'ZZZ::XXX'.
C26436: The type 'class YYY' with a virtual function needs either public virtual or protected non-virtual destructor (c.35).
C26440: Function 'XXX' can be declared 'noexcept' (f.6).
C26446: Prefer to use gsl::at() instead of unchecked subscript operator (bounds.4).
- at が使えるところは変更
- それ以外は gsl::at 相当のものを使用
C26447: The function is declared 'noexcept' but calls function 'XXX' which may throw exceptions (f.6).
- ちゃんと直すことにする
C26455: Default constructor may not throw. Declare it 'noexcept' (f.6).
C26461: The pointer argument 'xxx' for function 'XXX' can be marked as a pointer to const (con.3).
C26466: Don't use static_cast downcasts. A cast from a polymorphic type should use dynamic_cast (type.2).
- dynamic_cast は使わないので suppress
- 設計の問題のヒントになりうるので警告は除外しない
C26472: Don't use a static_cast for arithmetic conversions. Use brace initialization, gsl::narrow_cast or gsl::narrow (type.1).
- gsl::narrow 相当に対応したら消す
- それまでは除外
C26473: Don't cast between pointer types where the source type and the target type are the same (type.1).
C26477: Use 'nullptr' rather than 0 or NULL (es.47).
- テスト・サンプルソースは除外
C26481: Don't use pointer arithmetic. Use span instead (bounds.1).
- std::span を使う #633 で対応するので一旦除外
C26482: Only index into arrays using constant expressions (bounds.2).
- ignore
C26485: Expression 'func': No array to pointer decay (bounds.3).
- std::span を使う #633 で対応するので一旦除外
C26492: Don't use const_cast to cast away const or volatile (type.3).
- va_start が誤検知するのを抑止
C26493: Don't use C-style casts (type.4).
C26494: Variable 'XXX' is uninitialized. Always initialize an object (type.5).
C26495: Variable 'XXX::YYY' is uninitialized. Always initialize a member variable (type.6).
C26496: The variable 'XXX' does not change after construction, mark it as const (con.4).
C26497: You can attempt to make 'XXX' constexpr unless it contains any undefined behavior (f.4).
- テスト・サンプルソースは除外
C26814: The const variable 'XXX' can be computed at compile-time. Consider using constexpr (con.5).
- テスト・サンプルソースは除外
C26818: Switch statement does not cover all cases. Consider adding a 'default' label (es.79).
- 誤検知だったので SUPPRESS
C26826: Don't use C-style variable arguments (f.55).
- C++03 サポートするので対応しない。

include/internal/iutest_stdlib.hpp

include/internal/iutest_string.hpp

lgtm-com · 2022-02-16T02:30:14Z

This pull request introduces 1 alert when merging 2321845 into f4c5ea9 - view on LGTM.com

new alerts:

1 for FIXME comment

lgtm-com · 2022-02-16T12:22:15Z

This pull request introduces 1 alert when merging 25210ce into f4c5ea9 - view on LGTM.com

new alerts:

1 for FIXME comment

lgtm-com · 2022-02-17T03:01:59Z

This pull request introduces 1 alert when merging a5e5abe into a0cb0ff - view on LGTM.com

new alerts:

1 for FIXME comment

lgtm-com · 2022-03-02T15:25:49Z

This pull request introduces 1 alert when merging 1fd1714 into e444f55 - view on LGTM.com

new alerts:

1 for FIXME comment

ghost · 2022-03-11T22:59:21Z

include/internal/iutest_file.hpp

+    {
+        IUTEST_IGNORE_EXCEPTION_BEGIN()
+        {
+            Close();


[Clang-Tidy] Call to virtual method 'StdioFile::Close' during destruction bypasses virtual dispatch (view)

Rule Severity

clang-analyzer-optin.cplusplus.VirtualCall warning

You can close this issue if no need to fix it. Learn more.

ghost · 2022-03-11T22:59:22Z

include/listener/iutest_default_xml_generator.hpp

-        TestEnv::event_listeners().set_default_xml_generator(NULL);
+        IUTEST_IGNORE_EXCEPTION_BEGIN()
+        {
+            FileClose();


[Clang-Tidy] Call to virtual method 'DefaultXmlGeneratorListener::FileClose' during destruction bypasses virtual dispatch (view)

Rule Severity

clang-analyzer-optin.cplusplus.VirtualCall warning

You can close this issue if no need to fix it. Learn more.

lgtm-com · 2022-03-11T23:30:57Z

This pull request introduces 1 alert when merging 065f8a9 into e56ae1a - view on LGTM.com

new alerts:

1 for FIXME comment

lgtm-com · 2022-03-13T07:06:12Z

This pull request introduces 1 alert when merging fd0b7b6 into e56ae1a - view on LGTM.com

new alerts:

1 for FIXME comment

tools/fused/fused_iutest_files.py

lgtm-com · 2022-03-13T10:22:06Z

This pull request introduces 1 alert when merging 28b9d8b into e56ae1a - view on LGTM.com

new alerts:

1 for FIXME comment

lgtm-com · 2022-03-14T00:48:34Z

This pull request introduces 1 alert when merging 3d4e800 into e56ae1a - view on LGTM.com

new alerts:

1 for FIXME comment

lgtm-com · 2022-03-14T12:37:30Z

This pull request introduces 1 alert when merging 040a078 into e56ae1a - view on LGTM.com

new alerts:

1 for FIXME comment

lgtm-com · 2022-03-14T13:57:41Z

This pull request introduces 1 alert when merging fa06eb6 into e56ae1a - view on LGTM.com

new alerts:

1 for FIXME comment

lgtm-com · 2022-03-15T02:40:21Z

This pull request introduces 1 alert when merging b18bed4 into e56ae1a - view on LGTM.com

new alerts:

1 for FIXME comment

lgtm-com · 2022-03-15T12:56:10Z

This pull request introduces 1 alert when merging 6ca5cc2 into e56ae1a - view on LGTM.com

new alerts:

1 for FIXME comment

lgtm-com · 2022-03-16T01:03:18Z

This pull request introduces 1 alert when merging aeca0fb into e56ae1a - view on LGTM.com

new alerts:

1 for FIXME comment

srz-zumix added 4 commits November 9, 2021 11:13

Cpp Core Check

168f96d

vs2019

df5cfa0

up

3167124

fix

a0e9540

github-actions bot reviewed Nov 11, 2021

View reviewed changes

include/internal/iutest_stdlib.hpp Outdated Show resolved Hide resolved

ghost reviewed Nov 11, 2021

View reviewed changes

include/internal/iutest_stdlib.hpp Outdated Show resolved Hide resolved

srz-zumix added 14 commits November 11, 2021 09:48

oops

7539aa5

up

bb5f397

up

cb3e92e

NULL to IUTEST_NULLPTR

0fd47ba

inherit

efeda46

ForceImportBeforeCppTargets

c89a653

add options

c415873

fix path

764faeb

up

e23d7d6

up

e4a9c8d

Merge remote-tracking branch 'origin/develop' into appveyor/cppcorecheck

9e43d56

fix

2ef1ee8

up

1d369bc

fix

8b486ed

github-actions bot reviewed Nov 19, 2021

View reviewed changes

include/internal/iutest_string.hpp Outdated Show resolved Hide resolved

include/internal/iutest_string.hpp Outdated Show resolved Hide resolved

ghost reviewed Nov 19, 2021

View reviewed changes

include/internal/iutest_string.hpp Outdated Show resolved Hide resolved

include/internal/iutest_string.hpp Outdated Show resolved Hide resolved

srz-zumix added 8 commits November 19, 2021 20:45

fix

86e8fd8

fix

7548744

fix c++14 constexpr

83214c3

fix

1d8c4a5

fix

d2f01a9

fix

c90662a

fix

4559f91

fix

98fb734

fix C26440

25210ce

fix C26440

a5e5abe

fix

1fd1714

Merge remote-tracking branch 'origin/develop' into appveyor/cppcorecheck

065f8a9

ghost reviewed Mar 11, 2022

View reviewed changes

ignore C26826

fd0b7b6

fix fused

28b9d8b

ghost reviewed Mar 13, 2022

View reviewed changes

tools/fused/fused_iutest_files.py Outdated Show resolved Hide resolved

tools/fused/fused_iutest_files.py Outdated Show resolved Hide resolved

srz-zumix added 2 commits March 14, 2022 08:57

fix

ac17bdb

fix

3d4e800

fix

040a078

fix

fa06eb6

fix

b18bed4

fix

6ca5cc2

fix

aeca0fb

srz-zumix added 2 commits March 30, 2023 16:44

Merge remote-tracking branch 'origin/develop' into appveyor/cppcorecheck

83e99ad

fix

bebe474

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cpp Core Check #627

Cpp Core Check #627

srz-zumix commented Nov 9, 2021 •

edited

Loading

lgtm-com bot commented Feb 16, 2022

lgtm-com bot commented Feb 16, 2022

lgtm-com bot commented Feb 17, 2022

lgtm-com bot commented Mar 2, 2022

ghost Mar 11, 2022

ghost Mar 11, 2022

lgtm-com bot commented Mar 11, 2022

lgtm-com bot commented Mar 13, 2022

lgtm-com bot commented Mar 13, 2022

lgtm-com bot commented Mar 14, 2022

lgtm-com bot commented Mar 14, 2022

lgtm-com bot commented Mar 14, 2022

lgtm-com bot commented Mar 15, 2022

lgtm-com bot commented Mar 15, 2022

lgtm-com bot commented Mar 16, 2022

Cpp Core Check #627

Are you sure you want to change the base?

Cpp Core Check #627

Conversation

srz-zumix commented Nov 9, 2021 • edited Loading

lgtm-com bot commented Feb 16, 2022

lgtm-com bot commented Feb 16, 2022

lgtm-com bot commented Feb 17, 2022

lgtm-com bot commented Mar 2, 2022

ghost Mar 11, 2022

Choose a reason for hiding this comment

ghost Mar 11, 2022

Choose a reason for hiding this comment

lgtm-com bot commented Mar 11, 2022

lgtm-com bot commented Mar 13, 2022

lgtm-com bot commented Mar 13, 2022

lgtm-com bot commented Mar 14, 2022

lgtm-com bot commented Mar 14, 2022

lgtm-com bot commented Mar 14, 2022

lgtm-com bot commented Mar 15, 2022

lgtm-com bot commented Mar 15, 2022

lgtm-com bot commented Mar 16, 2022

srz-zumix commented Nov 9, 2021 •

edited

Loading