Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final refresh of progress bars when transform is complete #504

Merged
merged 3 commits into from
Nov 7, 2024

Conversation

ponyisi
Copy link
Collaborator

@ponyisi ponyisi commented Nov 1, 2024

Hopefully resolves #475 (though the issue is generally hard to reproduce these days). In any case doesn't do any harm.

Copy link

codecov bot commented Nov 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.66%. Comparing base (7105fd3) to head (91f478a).
Report is 8 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #504      +/-   ##
==========================================
+ Coverage   83.64%   84.66%   +1.02%     
==========================================
  Files          26       26              
  Lines        1461     1559      +98     
==========================================
+ Hits         1222     1320      +98     
  Misses        239      239              
Flag Coverage Δ
unittests 84.66% <100.00%> (+1.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kyungeonchoi kyungeonchoi merged commit 1c3d183 into master Nov 7, 2024
42 checks passed
@kyungeonchoi kyungeonchoi deleted the 475_progress_refresh branch November 7, 2024 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Download Progress bar doesn't complete
2 participants