Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do a preflight authentication call #520

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Do a preflight authentication call #520

merged 1 commit into from
Nov 15, 2024

Conversation

ponyisi
Copy link
Collaborator

@ponyisi ponyisi commented Nov 15, 2024

Resolves #506. Get authentication before actually doing submission, so we can raise an exception early and not hide it in the GuardList in the return value of deliver.

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.09%. Comparing base (c58c5aa) to head (6144050).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #520      +/-   ##
==========================================
- Coverage   83.86%   83.09%   -0.78%     
==========================================
  Files          27       27              
  Lines        1599     1674      +75     
==========================================
+ Hits         1341     1391      +50     
- Misses        258      283      +25     
Flag Coverage Δ
unittests 83.09% <100.00%> (-0.78%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ponyisi
Copy link
Collaborator Author

ponyisi commented Nov 15, 2024

I think the codecov issue is a false positive.

@kyungeonchoi kyungeonchoi self-requested a review November 15, 2024 20:39
Copy link
Contributor

@kyungeonchoi kyungeonchoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to have this fix! Thanks!

@kyungeonchoi kyungeonchoi merged commit f360c6a into master Nov 15, 2024
41 of 42 checks passed
@kyungeonchoi kyungeonchoi deleted the preflight_auth branch November 15, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do a pre-flight authentication check
2 participants