Move regular expressions #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support headers 4, 5 and 6
Requires Image enum value from `draft-js-utils`.
Support image export based on entity attributes
Fixed support for image type entity
per package.json and the contents of the LICENSE file
In the interest of improving regular expression performance, it makes sense to create each regular expression once, instead of re-creating every loop of `map`. These utility regular expressions and the methods that use them seemed better suited to their own file with documentation, so they can be tested individually.
sstur
force-pushed
the
master
branch
2 times, most recently
from
255f0a8 to
f6c1e51
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! Hopefully this is helpful. I noticed the regular expressions weren't being saved in a variable anywhere and were being created inside a
maploop so decided to change that. (general stack overflow comment that talks about this http://stackoverflow.com/a/32523333) and then made a new file to contain them and wrote some tests while I was at it...