-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrate from poetry to uv #43
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the linter checking markdown uses a default 80 char or something. There is a lot of unnecessary noise with newlines injected or moved to "fit" the contents when not needed.
I would prefer all changes introduced by this behavior to be reverted and have the tool "not care" about line length unless it goes beyond 120. The introduced noise causes reviews to be less focused on the important changes.
2003b4e
to
75dc561
Compare
75dc561
to
1ae1242
Compare
The npm package versions in CI are
which differs from package.json in the root of the repo
checks pass but running
I'm still not really sure why linting rules don't match formatting rules, I tried updating my local npm package versions to match ci, reinstall and rerun formatting and still got the same result. For now I suggest we don't use format-markdown to not block this PR because I think this issue is orthogonal to these changes. |
Description
This migrate the toml and Makefile to use uv instead of poetry. In the Makefile, commands are all using --python $(which python) to enable installing dependencies in the active environment. To install a contained mlm project environment that integrates with the uv lockfile, don't use the Makefile and instead use
uv sync
and other uv commands without the--python
flag.I also amended the precommit config to allow precommit to install and run with any python version not just python 3.10. Otherwise, my test of making a commit while running precommit in a conda environment running 3.11 was breaking. All make commands have been tested successfull as using a fresh conda environment.
For some reason, the make pre-commit-install command is the only command that still sets up a .venv in the mlm repo even though
--python $(which python)
is used. However the conda python env is still used to run precommit.ruff catches over 80 issues and fixes most of them. I added these in this PR to check actions since I updated actions.
Type of Change
Checklist
CONTRIBUTING.md
guide;make check
;Google
format for all the methods and classes that I used.