-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/add collection search extension V2 #736
Conversation
stac_fastapi/extensions/stac_fastapi/extensions/core/collection_search/request.py
Outdated
Show resolved
Hide resolved
this is ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool beans!
@jonhealy1 @vincentsarago I had another look at this and I'm wondering where the queryables enpoint is exposed. The filter extension, which is listed in the conformance classes, would require to be able to query based on queryables but I don't see where the link is added. Is that done in the backends? |
Yes that should be done by the users in their application. |
@vincentsarago Why though? If you have the filter extension enabled, you need the queryables link anyway. Could return an empty schema, but why this manual step? Related PR: stac-utils/stac-fastapi-pgstac#89 |
@m-mohr I'm not quite sure what you are asking to be honest. From the extension POV we cannot enforce the links to be present in the endpoints response 🤷 The if you add the |
@vincentsarago I'm missing the queryables link (not the endpoint itself) in If it needs to be added in the back-ends (as in the mentioned PR, although stac-utils/stac-fastapi-pgstac#89 (comment) is confusing then) it's fine, just feels conceptually a bit weird. |
👍 the links are added in the client as you did in the stac-FastAPI-pgstac PR |
simpler version of #681
This PR doesn't add the
/collections - POST
endpoint because:We could in another PR show (in the documentation) how to create a
/collections - POST
which support bothsearch and transaction
cc @tjellicoe-tpzuk