Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui): enhance Git Clone Dialog with modern design #1052

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat(ui): enhance Git Clone Dialog with modern design #1052

wants to merge 3 commits into from
+384 −82

Conversation

AbdullahOmar0
Copy link

@AbdullahOmar0 AbdullahOmar0 commented Jan 8, 2025 •
edited
Loading

Replace basic prompt with styled Radix UI dialog
Enhance input field and button styling

@AbdullahOmar0
feat(ui): Enhance Git Clone Dialog with modern design - Replace basic…
77f6753 
… prompt with styled Radix UI dialog - Add gradient background effects and blur overlay - Implement GitHub branding and improved layout - Enhance input field and button styling - Add backdrop blur for better focus management
@AbdullahOmar0 AbdullahOmar0 changed the title feat(ui): Enhance Git Clone Dialog with modern design feat(ui): enhance Git Clone Dialog with modern design Jan 8, 2025
@wonderwhy-er
Copy link
Collaborator

Add screenshot to PR

@wonderwhy-er
Copy link
Collaborator

Build also failed due to lock file

@AbdullahOmar0
Copy link
Author

screenshot
image

@AbdullahOmar0
Copy link
Author

Add screenshot to PR
image

@wonderwhy-er
Copy link
Collaborator

Build still fails, you need to updated lock file

@wonderwhy-er
Copy link
Collaborator

I see you updated versions of badrock and dialog
I guess those are only reason this even caused such large lock file changes...

@thecodacus
Copy link
Collaborator

thecodacus commented Jan 12, 2025 •
edited
Loading

just delete the package.lock.json its for npm
and use pnpm to install packages.

@leex279
Copy link
Collaborator

leex279 commented Jan 12, 2025

I would also appricate getting a hint/text what URL is needed, cause it also can be the "Clone" repo url, which is not working in this case or even better, we support both urls

@AbdullahOmar0
feat(ui): Enhance Git Clone Dialog with modern design
6f1ffb1 
- Replace basic prompt with styled Radix UI dialog
- Enhance input field and button styling
- Added GitHub logo SVG

chore: update pnpm lock file
@AbdullahOmar0
Copy link
Author

thx guys. updated

@leex279
Copy link
Collaborator

leex279 commented Jan 13, 2025

Maybe another PR, but I would expect to have the same UI for "Push to GitHub" as well. It´s "one" integration

@thecodacus
Copy link
Collaborator

thx guys. updated

can you remove the package-lock.json. its not required as npm is not used

@AbdullahOmar0
Copy link
Author

thx guys. updated

can you remove the package-lock.json. its not required as npm is not used

I just deleted it

@leex279 leex279 requested a review from thecodacus January 18, 2025 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Linkondanab Linkondanab Linkondanab approved these changes

@thecodacus thecodacus Awaiting requested review from thecodacus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AbdullahOmar0 @wonderwhy-er @thecodacus @leex279 @Linkondanab