refactor: simplify conditionals in propagate function for better read…

…ability
stackblitz · Dec 25, 2024 · 198c1b6 · 198c1b6
1 parent 1fca0d6
commit 198c1b6
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 20 deletions.
diff --git a/README.md b/README.md
@@ -97,16 +97,8 @@ export function propagate(link: Link, targetFlag: SubscriberFlags = SubscriberFl
 		const subFlags = sub.flags;
 
 		if (!(subFlags & SubscriberFlags.Tracking)) {
-			if (
-				(
-					!(subFlags & (SubscriberFlags.InnerEffectsPending | SubscriberFlags.ToCheckDirty | SubscriberFlags.Dirty))
-					&& (sub.flags = subFlags | targetFlag, true)
-				)
-				|| (
-					subFlags & SubscriberFlags.Recursed
-					&& (sub.flags = (subFlags & ~SubscriberFlags.Recursed) | targetFlag, true)
-				)
-			) {
+			if (!(subFlags & (SubscriberFlags.Recursed | SubscriberFlags.InnerEffectsPending | SubscriberFlags.ToCheckDirty | SubscriberFlags.Dirty))) {
+				sub.flags = (subFlags & ~SubscriberFlags.Recursed) | targetFlag;
 				const subSubs = (sub as Dependency).subs;
 				if (subSubs !== undefined) {
 					propagate(

diff --git a/src/system.ts b/src/system.ts
@@ -132,16 +132,8 @@ export function propagate(subs: Link): void {
 		const subFlags = sub.flags;
 
 		if (!(subFlags & SubscriberFlags.Tracking)) {
-			if (
-				(
-					!(subFlags & (SubscriberFlags.InnerEffectsPending | SubscriberFlags.ToCheckDirty | SubscriberFlags.Dirty))
-					&& (sub.flags = subFlags | targetFlag, true)
-				)
-				|| (
-					subFlags & SubscriberFlags.Recursed
-					&& (sub.flags = (subFlags & ~SubscriberFlags.Recursed) | targetFlag, true)
-				)
-			) {
+			if (!(subFlags & (SubscriberFlags.Recursed | SubscriberFlags.InnerEffectsPending | SubscriberFlags.ToCheckDirty | SubscriberFlags.Dirty))) {
+				sub.flags = (subFlags & ~SubscriberFlags.Recursed) | targetFlag;
 				const subSubs = (sub as Dependency).subs;
 				if (subSubs !== undefined) {
 					if (subSubs.nextSub !== undefined) {