refactor: avoid using export * as for tree-shaking friendly
#28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
PuruVJ
commented
Dec 25, 2024
johnsoncodehk
changed the title
unstable[dot] with unstable_export * as for tree-shaking friendly
|
If we change the export interface we have to release 0.5 to avoid breakage, so we have simply removed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shipping the unstable module as
export * as unstable from './unstable/index.js'does not let this library be tree-shaken.This PR re-exports all methods from unstable with an
unstable_prefix, which makes it tree-shakeable once again, while only needing to replace one character([dot]with_underscore)Fixes #27