Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Custom Angular Builder with Standard Angular CLI Builder #50

Merged
merged 2 commits into from
Jan 9, 2025

Conversation

JeevanMahesha
Copy link
Contributor

This PR resolves the issue where the Angular build process fails with the error Angular compilation initialization failed when using template literals for styles (styles: ...``).

Fix for #49

@JeevanMahesha
Copy link
Contributor Author

JeevanMahesha commented Jan 4, 2025

@d3lm / @sulco / @kirjavascript / @Nemikolh can you please review this PR.

Copy link
Member

@Nemikolh Nemikolh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for looking into this 🙌

@JeevanMahesha
Copy link
Contributor Author

@Nemikolh can we merged this changes please.

@Nemikolh
Copy link
Member

Nemikolh commented Jan 9, 2025

Yup!

@Nemikolh Nemikolh merged commit 6d56092 into stackblitz:main Jan 9, 2025
2 checks passed
alxhub added a commit to alxhub/starters that referenced this pull request Jan 10, 2025
…gular CLI Builder (stackblitz#50)"

This reverts commit 6d56092.

Reason: broken angular.json configuration
apai4 pushed a commit that referenced this pull request Jan 10, 2025
…gular CLI Builder (#50)" (#52)

This reverts commit 6d56092.

Reason: broken angular.json configuration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants