Only attempt payment 3 times

api/paidAction/index.js

@@ -328,7 +328,9 @@ export async function retryPaidAction (actionType, args, incomingContext) {
     me: await models.user.findUnique({ where: { id: parseInt(me.id) } }),
     cost: BigInt(msatsRequested),
     actionId,
-    predecessorId: failedInvoice.id
+    predecessorId: failedInvoice.id,
+    // a locked invoice means we're retrying a payment from the beginning with all sender and receiver wallets
+    retry: failedInvoice.lockedAt ? failedInvoice.retry + 1 : failedInvoice.retry
   }
 
   let invoiceArgs
@@ -419,7 +421,7 @@ async function createSNInvoice (actionType, args, context) {
 }
 
 async function createDbInvoice (actionType, args, context) {
-  const { me, models, tx, cost, optimistic, actionId, invoiceArgs, predecessorId } = context
+  const { me, models, tx, cost, optimistic, actionId, invoiceArgs, retry, predecessorId } = context
   const { bolt11, wrappedBolt11, preimage, wallet, maxFee } = invoiceArgs
 
   const db = tx ?? models
@@ -445,6 +447,7 @@ async function createDbInvoice (actionType, args, context) {
     actionArgs: args,
     expiresAt,
     actionId,
+    retry,
     predecessorId
   }
 

api/resolvers/paidAction.js

@@ -67,6 +67,10 @@ export default {
         throw new Error(`Invoice is not in failed state: ${invoice.actionState}`)
       }
 
+      if (invoice.retry > 2) {
+        throw new Error('Payment has been retried too many times')
+      }
+
       const result = await retryPaidAction(invoice.actionType, { invoice }, { models, me, lnd })
 
       return {

api/resolvers/wallet.js

@@ -480,6 +480,7 @@ const resolvers = {
               "cancelledAt" + $3::interval
             )
             AND "lockedAt" IS NULL
+            AND "retry" < 2
             ORDER BY id DESC
             FOR UPDATE SKIP LOCKED
           )

prisma/migrations/20250107084543_invoice_retry_count/migration.sql

@@ -0,0 +1,2 @@
+-- AlterTable
+ALTER TABLE "Invoice" ADD COLUMN     "retry" INTEGER NOT NULL DEFAULT 0;

prisma/schema.prisma

@@ -925,6 +925,7 @@ model Invoice {
   cancelledAt        DateTime?
   userCancel         Boolean?
   lockedAt           DateTime?
+  retry              Int                 @default(0)
   msatsRequested     BigInt
   msatsReceived      BigInt?
   desc               String?

wallets/server.js

@@ -24,9 +24,13 @@ export default [lnd, cln, lnAddr, lnbits, nwc, phoenixd, blink, lnc, webln]
 
 const MAX_PENDING_INVOICES_PER_WALLET = 25
 
-export async function createInvoice (userId, { msats, description, descriptionHash, expiry = 360 }, { predecessorId, models }) {
+export async function createInvoice (userId, { msats, description, descriptionHash, expiry = 360 }, { retry, predecessorId, models }) {
   // get the wallets in order of priority
-  const wallets = await getInvoiceableWallets(userId, { predecessorId, models })
+  const wallets = await getInvoiceableWallets(userId, {
+    retry,
+    predecessorId,
+    models
+  })
 
   msats = toPositiveNumber(msats)
 
@@ -81,7 +85,7 @@ export async function createInvoice (userId, { msats, description, descriptionHa
 
 export async function createWrappedInvoice (userId,
   { msats, feePercent, description, descriptionHash, expiry = 360 },
-  { predecessorId, models, me, lnd }) {
+  { retry, predecessorId, models, me, lnd }) {
   let logger, bolt11
   try {
     const { invoice, wallet } = await createInvoice(userId, {
@@ -90,7 +94,7 @@ export async function createWrappedInvoice (userId,
       description,
       descriptionHash,
       expiry
-    }, { predecessorId, models })
+    }, { retry, predecessorId, models })
 
     logger = walletLogger({ wallet, models })
     bolt11 = invoice
@@ -110,7 +114,7 @@ export async function createWrappedInvoice (userId,
   }
 }
 
-export async function getInvoiceableWallets (userId, { predecessorId, models }) {
+export async function getInvoiceableWallets (userId, { retry, predecessorId, models }) {
   // filter out all wallets that have already been tried by recursively following the retry chain of predecessor invoices.
   // the current predecessor invoice is in state 'FAILED' and not in state 'RETRYING' because we are currently retrying it
   // so it has not been updated yet.
@@ -143,6 +147,7 @@ export async function getInvoiceableWallets (userId, { predecessorId, models })
           FROM "Invoice"
           JOIN "Retries" ON "Invoice"."id" = "Retries"."predecessorId"
           WHERE "Invoice"."actionState" = 'RETRYING'
+          AND "Invoice"."retry" = ${retry}
         )
         SELECT
           "InvoiceForward"."walletId"