Skip to content

Commit

Permalink
Revert "chore: temporarily disabled compare steps"
Browse files Browse the repository at this point in the history
This reverts commit fcbdea9.
  • Loading branch information
aegroto committed Dec 3, 2024
1 parent f5a67ac commit de3562f
Showing 1 changed file with 57 additions and 43 deletions.
100 changes: 57 additions & 43 deletions .github/workflows/nextjs_bundle_analysis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -69,46 +69,60 @@ jobs:
name: bundle
path: .next/analyze/__bundle_analysis.json

# - name: Download base branch bundle stats
# uses: dawidd6/action-download-artifact@v2
# if: success() && github.event.number
# with:
# workflow: nextjs_bundle_analysis.yml
# branch: ${{ github.event.pull_request.base.ref }}
# path: .next/analyze/base

# - name: Compare with base branch bundle
# if: success() && github.event.number
# run: ls -laR .next/analyze/base && npx -p nextjs-bundle-analysis compare

# - name: Get Comment Body
# id: get-comment-body
# if: success() && github.event.number
# run: |
# echo "body<<EOF" >> $GITHUB_OUTPUT
# echo "$(cat .next/analyze/__bundle_analysis_comment.txt)" >> $GITHUB_OUTPUT
# echo EOF >> $GITHUB_OUTPUT

# - name: Find Comment
# uses: peter-evans/find-comment@v2
# if: success() && github.event.number
# id: fc
# with:
# issue-number: ${{ github.event.number }}
# body-includes: '<!-- __NEXTJS_BUNDLE -->'

# - name: Create Comment
# uses: peter-evans/create-or-update-comment@v2
# if: success() && github.event.number && steps.fc.outputs.comment-id == 0
# with:
# issue-number: ${{ github.event.number }}
# body: ${{ steps.get-comment-body.outputs.body }}

# - name: Update Comment
# uses: peter-evans/create-or-update-comment@v2
# if: success() && github.event.number && steps.fc.outputs.comment-id != 0
# with:
# issue-number: ${{ github.event.number }}
# body: ${{ steps.get-comment-body.outputs.body }}
# comment-id: ${{ steps.fc.outputs.comment-id }}
# edit-mode: replace
- name: Download base branch bundle stats
uses: dawidd6/action-download-artifact@v2
if: success() && github.event.number
with:
workflow: nextjs_bundle_analysis.yml
branch: ${{ github.event.pull_request.base.ref }}
path: .next/analyze/base

# And here's the second place - this runs after we have both the current and
# base branch bundle stats, and will compare them to determine what changed.
# There are two configurable arguments that come from package.json:
#
# - budget: optional, set a budget (bytes) against which size changes are measured
# it's set to 350kb here by default, as informed by the following piece:
# https://infrequently.org/2021/03/the-performance-inequality-gap/
#
# - red-status-percentage: sets the percent size increase where you get a red
# status indicator, defaults to 20%
#
# Either of these arguments can be changed or removed by editing the `nextBundleAnalysis`
# entry in your package.json file.
- name: Compare with base branch bundle
if: success() && github.event.number
run: ls -laR .next/analyze/base && npx -p nextjs-bundle-analysis compare

- name: Get Comment Body
id: get-comment-body
if: success() && github.event.number
# https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#multiline-strings
run: |
echo "body<<EOF" >> $GITHUB_OUTPUT
echo "$(cat .next/analyze/__bundle_analysis_comment.txt)" >> $GITHUB_OUTPUT
echo EOF >> $GITHUB_OUTPUT
- name: Find Comment
uses: peter-evans/find-comment@v2
if: success() && github.event.number
id: fc
with:
issue-number: ${{ github.event.number }}
body-includes: '<!-- __NEXTJS_BUNDLE -->'

- name: Create Comment
uses: peter-evans/create-or-update-comment@v2
if: success() && github.event.number && steps.fc.outputs.comment-id == 0
with:
issue-number: ${{ github.event.number }}
body: ${{ steps.get-comment-body.outputs.body }}

- name: Update Comment
uses: peter-evans/create-or-update-comment@v2
if: success() && github.event.number && steps.fc.outputs.comment-id != 0
with:
issue-number: ${{ github.event.number }}
body: ${{ steps.get-comment-body.outputs.body }}
comment-id: ${{ steps.fc.outputs.comment-id }}
edit-mode: replace

0 comments on commit de3562f

Please sign in to comment.