make action state transitions only happen once

stackernews · May 28, 2024 · e6c5149 · e6c5149
1 parent 8745abb
commit e6c5149
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/worker/paidAction.js b/worker/paidAction.js
@@ -5,10 +5,10 @@ export async function settleAction ({ data: { invoiceId }, models }) {
     where: { id: invoiceId }
   })
 
-  // TODO: ensure that this is done only once
   await models.$transaction([
+    // optimistic concurrency control (aborts if invoice is not in PENDING state)
     models.invoice.update({
-      where: { id: invoice.id },
+      where: { id: invoice.id, actionState: 'PENDING' },
       data: { actionState: 'PAID' }
     }),
     ...await paidActions[invoice.actionType].onPaidStatements({ invoice }, { models })
@@ -20,10 +20,10 @@ export async function settleActionError ({ data: { invoiceId }, models }) {
     where: { id: invoiceId }
   })
 
-  // TODO: ensure that this is done only once
   await models.$transaction([
+    // optimistic concurrency control (aborts if invoice is not in PENDING state)
     models.invoice.update({
-      where: { id: invoice.id },
+      where: { id: invoice.id, actionState: 'PENDING' },
       data: { actionState: 'FAILED' }
     }),
     ...await paidActions[invoice.actionType].onFailedStatements({ invoice }, { models })