Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Related section not collapsed after first reply #837

Closed
ekzyis opened this issue Feb 15, 2024 · 4 comments · Fixed by #1207
Closed

Related section not collapsed after first reply #837

ekzyis opened this issue Feb 15, 2024 · 4 comments · Fixed by #1207
Assignees
@tsmith123
Labels
difficulty:easy feature new product features that weren't there before priority:high ux

Comments

@ekzyis
Copy link
Member

ekzyis commented Feb 15, 2024 •
edited by huumn
Loading

https://stacker.news/items/426061

We want to keep this functionality but it should collapse related posts on the first comment submission.
@ekzyis ekzyis added the bug label Feb 15, 2024
@huumn huumn added feature new product features that weren't there before difficulty:good-first-issue ux and removed bug labels Feb 15, 2024
@abhiShandy
Copy link
Contributor

This issue was fixed by dc8d35f

@ekzyis
Copy link
Member Author

ekzyis commented Apr 6, 2024 •
edited
Loading

dc8d35f is related but this change only collapses the related section when you load the page again. This ticket is about updating the Apollo cache so you don't have to reload the page after you replied. See this video:

2024-04-06.18-12-37.mp4

@tsmith123 tsmith123 self-assigned this May 28, 2024
@tsmith123 tsmith123 mentioned this issue May 29, 2024
Merged
@tsmith123
Copy link
Contributor

Turned out that the issue wasn't really to do with Apollo cache but the Accordion component instead. Tricky one to find but added a PR here #1207

@ekzyis
Copy link
Member Author

ekzyis commented May 30, 2024

Oh, I thought it might be controlled via the Apollo cache but I didn't look at the code. Sorry for the false pointer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsmith123 tsmith123

Labels
difficulty:easy feature new product features that weren't there before priority:high ux
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Close related section tsmith123/stacker.news
4 participants
@abhiShandy @tsmith123 @ekzyis @huumn