Close related section #1207
Merged
Close related section #1207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekzyis
reviewed
May 30, 2024
ekzyis
reviewed
May 30, 2024
|
Thanks @ekzyis - good spot on the conditional. I've put that back. My testing was done with the proper conditional btw. |
ekzyis
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #837
Description
This PR ensures that the Related Posts section is closed once a comment is made.
This issue took me a while to find but eventually found the problem within Accordion component.
activeKeyandonSelectpropsonSelecthandler to updateactiveKeyvalueactiveKeyvalue on loadnullinstead ofundefined(Accordion doesn't seem to behave when usingundefined)Video
Screen.Recording.2024-05-29.at.11.54.24.mov
Testing
Please QA this if possible as I may have overlooked something.