Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show Alert Message on Settings Page #1179

Merged
merged 5 commits into from
May 17, 2024

Conversation

tsmith123
Copy link
Contributor

@tsmith123 tsmith123 commented May 17, 2024

Fixes #790

Description

This PR renders an alert message on the settings page when only a single auth method is activated.

Screenshots

Desktop
Screenshot 2024-05-17 at 15 05 57

Mobile
Screenshot 2024-05-17 at 15 06 04

Copy link
Contributor

coderabbitai bot commented May 17, 2024

Walkthrough

Walkthrough

The recent changes introduce a function called showAuthWarning in the settings page to alert users when only one authentication method is linked. This aims to prevent users from losing account access due to changes in their linked authentication method. Additionally, a new CSS style for .alert has been added to visually emphasize the warning by setting its color to red.

Changes

File Summary
pages/settings/index.js Added showAuthWarning function to display an alert if only one authentication method is activated.
pages/settings/settings.module.css Introduced a new CSS style for the .alert class, setting its color to red.

Assessment against linked issues

Objective Addressed Explanation
Display a warning on the settings page when only one auth method is linked (#790)

Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 42891ea and deeac8b.
Files selected for processing (2)
  • pages/settings/index.js (3 hunks)
  • pages/settings/settings.module.css (1 hunks)
Files skipped from review as they are similar to previous changes (2)
  • pages/settings/index.js
  • pages/settings/settings.module.css

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@tsmith123 tsmith123 requested a review from huumn May 17, 2024 07:14
@tsmith123 tsmith123 assigned tsmith123 and unassigned tsmith123 May 17, 2024
@huumn
Copy link
Member

huumn commented May 17, 2024

I've been waiting for someone to pick this up!

Two things:

  1. I think this should be for any auth method
  2. It should be at the top of the settings page

While lnurl auth problems are the most common, we've had people lose access to email address and twitter auth before.

@tsmith123
Copy link
Contributor Author

Ah, no problem. Was a bit unsure of the requirements. Changes pushed and I've updated the screenshots to show how the message at the top will look.

@tsmith123 tsmith123 changed the title Show Alert Message For LNauth Auth Users Show Alert Message For LNauth Users May 17, 2024
@tsmith123 tsmith123 changed the title Show Alert Message For LNauth Users Show Alert Message on Settings Page May 17, 2024
@huumn huumn merged commit 2b2f2d5 into stackernews:master May 17, 2024
6 checks passed
@tsmith123 tsmith123 deleted the settings-page-alert branch November 21, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add alert to settings page when only one auth method is linked
2 participants