Replace toasts - be more optimistic - prepaid and postpaid #1184
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,7 +4,7 @@ import { GraphQLError } from 'graphql' | |
| import { decodeCursor, LIMIT, nextCursorEncoded } from '@/lib/cursor' | ||
| import { msatsToSats } from '@/lib/format' | ||
| import { bioSchema, emailSchema, settingsSchema, ssValidate, userSchema } from '@/lib/validate' | ||
| import { getItem, updateItem, filterClause, createItem, whereClause, muteClause, statusClause } from './item' | ||
| import { ANON_USER_ID, DELETE_USER_ID, RESERVED_MAX_USER_ID, SN_NO_REWARDS_IDS } from '@/lib/constants' | ||
| import { viewGroup } from './growth' | ||
| import { timeUnitForRange, whenRange } from '@/lib/time' | ||
|
|
@@ -285,6 +285,7 @@ export default { | |
| 'r.created_at >= "ThreadSubscription".created_at', | ||
| await filterClause(me, models), | ||
| muteClause(me), | ||
| statusClause(me), | ||
| ...(user.noteAllDescendants ? [] : ['r.level = 1']) | ||
| )})`, me.id, lastChecked) | ||
| if (newThreadSubReply.exists) { | ||
|
|
@@ -305,7 +306,8 @@ export default { | |
| OR ("Item"."parentId" IS NOT NULL AND "UserSubscription"."commentsSubscribedAt" IS NOT NULL AND "Item".created_at >= "UserSubscription"."commentsSubscribedAt") | ||
| )`, | ||
| await filterClause(me, models), | ||
| muteClause(me), | ||
| statusClause(me))})`, me.id, lastChecked) | ||
| if (newUserSubs.exists) { | ||
| foundNotes() | ||
| return true | ||
|
|
@@ -339,7 +341,8 @@ export default { | |
| '"Mention".created_at > $2', | ||
| '"Item"."userId" <> $1', | ||
| await filterClause(me, models), | ||
| muteClause(me), | ||
| statusClause(me) | ||
| )})`, me.id, lastChecked) | ||
| if (newMentions.exists) { | ||
| foundNotes() | ||
|
|
@@ -503,6 +506,20 @@ export default { | |
| return true | ||
| } | ||
|
|
||
| const newFailedItems = await models.item.findFirst({ | ||
| where: { | ||
| userId: me.id, | ||
| status: 'FAILED', | ||
| updatedAt: { | ||
| gt: lastChecked | ||
| } | ||
| } | ||
| }) | ||
| if (newFailedItems) { | ||
| foundNotes() | ||
| return true | ||
| } | ||
|
Comment on lines
+509
to
+521
There was a problem hiding this comment. Consider optimizing the query for checking new failed items. The current implementation performs a query for each type of notification. This could potentially be optimized by combining some of these queries into a single query, especially if they are checking similar conditions or can be grouped logically. There was a problem hiding this comment. This comment reminds me that I probably need to manually update There was a problem hiding this comment. @ekzyis, you're absolutely right about the need to manually update the If you're updating multiple records or have multiple places where this needs to be handled, you might consider abstracting this logic into a helper function or middleware to keep your code DRY and maintainable. Here’s a quick example of how you might implement such a function in JavaScript: const updateWithTimestamp = async (model, where, data) => {
const updatedAt = new Date();
const updatedData = { ...data, updatedAt };
return await model.update({ where, data: updatedData });
};This function takes the model, the conditions ( Let me know if you need further assistance with this or any other part of your implementation! There was a problem hiding this comment. Mhh, even though I don't see a trigger that does this, These are the existing item triggers: There was a problem hiding this comment. @ekzyis, it's interesting to see that the
If you need to confirm or inspect this behavior further, you might consider checking the definition of the Let me know if you need more detailed information on this or any other queries! |
||
|
|
||
| // update checkedNotesAt to prevent rechecking same time period | ||
| models.user.update({ | ||
| where: { id: me.id }, | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tip
Codebase Verification
Ensure proper error handling for external calls to
createInvoice.The search results indicate multiple instances of
createInvoicecalls across various files. However, not all instances show explicit error handling. Specifically, inapi/resolvers/item.js, there is no clear indication of error handling around thecreateInvoicecall.api/resolvers/item.js: Ensure that thecreateInvoicecall is wrapped in a try-catch block or has appropriate error handling mechanisms.Analysis chain
Ensure proper error handling for external calls to
createInvoice.Scripts Executed
The following scripts were executed for the analysis:
Script:
Length of output: 75
Script:
Length of output: 13248