Remove Referral Notifications #1211
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@huumn There are still a few files left that reference Not sure if these should remain for the integrity of the data that exists already? 🤔 |
huumn
reviewed
Jun 23, 2024
Comment on lines
-256
to
-265
| queries.push( | ||
| `(SELECT "Invite".id, MAX(users.created_at) AS "sortTime", NULL as "earnedSats", | ||
| 'Invitification' AS type | ||
| FROM users JOIN "Invite" on users."inviteId" = "Invite".id | ||
| WHERE "Invite"."userId" = $1 | ||
| AND users.created_at < $2 | ||
| GROUP BY "Invite".id | ||
| ORDER BY "sortTime" DESC | ||
| LIMIT ${LIMIT})` | ||
| ) |
There was a problem hiding this comment.
We want to keep these ones. It's just the referrals we are axing.
huumn
reviewed
Jun 23, 2024
Comment on lines
-454
to
-463
| const [newInvites] = await models.$queryRawUnsafe(` | ||
| SELECT EXISTS( | ||
| SELECT * | ||
| FROM users JOIN "Invite" on users."inviteId" = "Invite".id | ||
| WHERE "Invite"."userId" = $1 | ||
| AND users.created_at > $2)`, me.id, lastChecked) | ||
| if (newInvites.exists) { | ||
| foundNotes() | ||
| return true | ||
| } |
There was a problem hiding this comment.
Likewise, we want to keep the invites.
|
We mostly just want to remove the notifications and notification indicator for referrals. Everything else can stay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1047
Description
This PR removes the logic for referral notification as it isn't required anymore. See #1047 for further details.