Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: clustered ffmpeg transcoding #1653

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Soxasora
Copy link
Member

Description

Clustered FFmpeg transcoding for video uploads

Proof-of-concept with Node and Express acting as a master server that queue transcoding jobs to be picked up by its defined workers.
It enables transcoding for video uploads streamlining compatibility across devices.

Screenshots

n/a

Additional Context

Transcoding requires some time and it can add a noticeable overhead on video uploads. The result video is a slimmed, color corrected mp4 file.

note: this is not a well-tested feature and nowhere near ready for production, I halted development on this to explore other solutions
note 2: this transcodes every video file to mp4, could also allow only video/quicktime mime type to act as a last-resort option

Checklist

Are your changes backwards compatible? Please answer below:
Doesn't interfere with video playback, it's a new step while uploading that only happens when the file is a video.

On a scale of 1-10 how well and how have you QA'd this change and any features it might affect? Please answer below:
5.
Tried with 4 workers and 8 simultaneous uploads, enqueueing correctly the jobs until workers were available.
An 18 MB 720p mov file was correctly transcoded to 13 MB 720p mp4 file.

For frontend changes: Tested on mobile, light and dark mode? Please answer below: n/a

Did you introduce any new environment variables? If so, call them out explicitly here:

# .env.development
# ffmpeg
NEXT_PUBLIC_FFMPEG_URL=http://localhost:3002
FFMPEG_PORT=3002
FFMPEG_WORKERS=4

Copy link

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected] filesystem Transitive: environment +17 456 kB linusu

View full report↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant