Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Depends on #1680
Together with #1680 closes #1439 .
This PR adds 2fa for high risk mutations.
Whenever the user triggers a mutation that we deem high risk (eg. big zap, territory transfer...) a 2fa prompt shows.
The mutation gets rejected if the user doesn't complete the 2fa.
Screenshots
2024-12-05.16-15-06.mp4
Additional Context
I've implemented this as an
Apollo Server plugin
andApollo Client link
.To mark a mutation as high risk (both for server and client) it needs to be included in the
HighRiskMutationFields
array inlib/auth2fa
. TheHighRiskMutationFields
array can contain also functions that are used to do some more advanced filteringeg.
Once the mutation is marked as high risk, everything is handled automatically by the plugin, there is no need to make the resolver aware it is running an high risk mutation.
However as debug and hardening resource, resolvers triggered by a request that contains an highrisk mutation, will receive an
highRisk
field in theircontext
, this field is an object defined as:that can be used to do additional checks or assertions
Checklist
Are your changes backwards compatible? Please answer below:
yes
On a scale of 1-10 how well and how have you QA'd this change and any features it might affect? Please answer below:
8
For frontend changes: Tested on mobile, light and dark mode? Please answer below:
yes
Did you introduce any new environment variables? If so, call them out explicitly here:
no