Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine #1739 and fix regression causing nostr crossposts and login to not work #1740

Merged
merged 2 commits into from
Dec 19, 2024

Conversation

riccardobl
Copy link
Member

@riccardobl riccardobl commented Dec 19, 2024

This PR

@riccardobl riccardobl changed the title Refine #1739 and fix regression causing crossposts and login to not work Refine #1739 and fix regression causing nostr crossposts and login to not work Dec 19, 2024
Copy link
Member

@ekzyis ekzyis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need a global instance for remote signing? Can't we always create a new instance and then destroy it with nostr.close()? I think it's confusing to use a global instance and individual instances in our code.

Otherwise looks good but I did not test.

@riccardobl
Copy link
Member Author

Yes, we can use a new instance for remote signing.
The singleton is important only serverside, really.

@riccardobl riccardobl requested a review from ekzyis December 19, 2024 14:02
@huumn huumn merged commit e4ca2d6 into stackernews:master Dec 19, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug report nip46 login shows error "m.ZP.getSigner is not a function"
3 participants