Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix upvote button shown for deleted items #1753

Merged
merged 1 commit into from
Dec 21, 2024

Conversation

ekzyis
Copy link
Member

@ekzyis ekzyis commented Dec 20, 2024

Description

I tried to find the changes that broke this to have full context and see if I am missing something but I can't tell.

Using git blame on components/upvote.module.css (because that's where I fixed it) shows 5f0494d but I don't think this was broken since we shipped #1408.

Using git log -G "deletedAt" I find following commits but from looking into them, I also can't tell which one broke it:

$ git log --oneline --no-decorate -G "deletedAt" -10
6d9db696 Fix upvote button shown for deleted items
b8061a63 don't double factor trust
6d4dfdda improve rewards (#1731)
01d51770 Fix edit timer stuck at 00:00 (#1673)
8a2bd84f fix: upvote widget not rendered when comment is collapsed (#1583)
fdd34b2e Fix edit countdown on deleted items (#1571)
9f06fd65 UX latency enhancements for paid actions (#1434)
5f0494de rethinking boost (#1408)
e63609a7 don't show deleted items in main sorts
5e771062 Undelete bio items (#1346)

So I am not sure if I am missing something but looks good to me. Boost and upvote icon disappears now for deleted items.

Checklist

Are your changes backwards compatible? Please answer below:

yes

On a scale of 1-10 how well and how have you QA'd this change and any features it might affect? Please answer below:

5. Tested deleted items of self and deleted items of others. Upbolt and boost icon disappeared on delete.

For frontend changes: Tested on mobile, light and dark mode? Please answer below:

n/a

Did you introduce any new environment variables? If so, call them out explicitly here:

no

@ekzyis ekzyis added the bug label Dec 20, 2024
@huumn huumn merged commit 0ca3703 into master Dec 21, 2024
6 checks passed
@huumn huumn deleted the fix-deleted-items-show-upvote-button branch December 21, 2024 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants