Fix upvote button shown for deleted items #1753
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I tried to find the changes that broke this to have full context and see if I am missing something but I can't tell.
Using
git blame
on components/upvote.module.css (because that's where I fixed it) shows 5f0494d but I don't think this was broken since we shipped #1408.Using
git log -G "deletedAt"
I find following commits but from looking into them, I also can't tell which one broke it:So I am not sure if I am missing something but looks good to me. Boost and upvote icon disappears now for deleted items.
Checklist
Are your changes backwards compatible? Please answer below:
yes
On a scale of 1-10 how well and how have you QA'd this change and any features it might affect? Please answer below:
5
. Tested deleted items of self and deleted items of others. Upbolt and boost icon disappeared on delete.For frontend changes: Tested on mobile, light and dark mode? Please answer below:
n/a
Did you introduce any new environment variables? If so, call them out explicitly here:
no