Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If an invoice cancel fails, we currently only log the error and return
undefined
and then throw in the constructor ofInvoiceCanceledError
becauseinvoice
is undefined. This results in an uncaughtUnhandled Runtime Error
.This change doesn't change that cancel errors result in an unhandled runtime error, but it will at least show the proper error.
According to NextJS docs, these unhandled runtime errors don't show up in prod. I assume they just get logged to console but don't crash the app? Not sure though.
But anyway, so far we never had an invoice cancel fail and this is just about throwing the actual error.
Checklist
Are your changes backwards compatible? Please answer below:
yes
On a scale of 1-10 how well and how have you QA'd this change and any features it might affect? Please answer below:
9
. Works on successful cancel. If I thrownew Error("test")
in the backend, it actually shows me that error in the overlay.For frontend changes: Tested on mobile, light and dark mode? Please answer below:
n/a
Did you introduce any new environment variables? If so, call them out explicitly here:
no