Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for Sentinel-1 SLCs #57

Merged
merged 16 commits into from
Oct 19, 2023

Conversation

constantinius
Copy link
Contributor

@constantinius constantinius commented Oct 4, 2023

This PR aims to provide support for Sentinel-1 SLCs

Since these products differ in some ways from GRD or other product types, they are placed under their own namespace.

In order to reduce the surface size, it extracts commonalities with GRDs and creates subclasses for product discovery and metadata extraction.

Initial implementation work done by @peterfriedl

Fixing upper/lower casing of extracted values
Adding test SAFE package
Fixing GRD tests
@constantinius constantinius marked this pull request as ready for review October 5, 2023 07:36
@constantinius
Copy link
Contributor Author

@gadomski did you have a chance to look at this? Do you know why the codecov check is failing?

@gadomski gadomski self-requested a review October 17, 2023 13:05
Copy link
Contributor

@gadomski gadomski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've got the codecov fixed, in general looks great! Just a couple little cleanup requests.

@gadomski gadomski enabled auto-merge (rebase) October 17, 2023 16:45
auto-merge was automatically disabled October 19, 2023 12:18

Head branch was pushed to by a user without write access

@gadomski gadomski enabled auto-merge (rebase) October 19, 2023 12:28
@gadomski gadomski merged commit e952198 into stactools-packages:main Oct 19, 2023
5 checks passed
@constantinius constantinius deleted the slc-support branch October 19, 2023 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants