Add padding while saving ivf.pid.pt and release GIL #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The padding sems to interfere when utilising Specifically, there's an assert statement in the function that checks the length and the zero paddings results in an error. ColBERT/colbert/index_updater.py Line 418 in 7067ef5 submitted #380 to handle the padded zeros. Also mentioned in this #369 (comment) |
erjieyong
added a commit
to erjieyong/ColBERT
that referenced
this pull request
Dec 2, 2024
to account for padded zeros added by stanford-futuredata#336
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We append the padding before saving ivf.pid.pt. This is so that when we load this back, we can avoid the memory spike caused while appending the padding after loading. Functionally, there is no difference.
Also GIL is released for more parallelism.