Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set hrpsys version greater than 315.2.0 #460

Merged
merged 1 commit into from
Jun 12, 2014

Conversation

k-okada
Copy link
Member

@k-okada k-okada commented May 14, 2014

No description provided.

@130s
Copy link
Contributor

130s commented May 14, 2014

Though not so sure, we might need CATKIN_DEPENDS on the gte-specified package in CMakeLists.txt, in order to invoke the version checking (see).

catkin_package(
  :
  CATKIN_DEPENDS ... hrpsys ...
  :
)

I also want to note that how useful version_gte tag is not clear to me; in my experience it only gives "warning" when I catkin_make and didn't return error.

@k-okada
Copy link
Member Author

k-okada commented May 14, 2014

I see, I'm trying to move to the last step of #449.

Since hrpsys is already move to 315.2.0 ( which is still compatible with 315.1.x in terms of StableRTC layer) and would like to move version of rtmros_common to 1.2.0. (minor number of rtmros_common will match to minor version of hrpsys)

However there are no difference between 1.0.20 and 2.x.0, so I just to make some commit, just to add something in CHANGELOG, but as you commented if version_gte is not working, I'll close this PR without merging.

@k-okada k-okada closed this May 14, 2014
@k-okada k-okada deleted the hrpsys_version_gte branch May 14, 2014 04:45
@130s
Copy link
Contributor

130s commented May 29, 2014

Depending on how you wanted to use version_gte, it's still valid to add it I think. For example it can specifically warn people who look either at package.xml or at the output from catkin, about the version requirement.

@k-okada k-okada restored the hrpsys_version_gte branch June 2, 2014 03:17
@k-okada k-okada reopened this Jun 2, 2014
@k-okada
Copy link
Member Author

k-okada commented Jun 2, 2014

ok, I reopened the PR, please merge if you think it is vaulale

@130s
Copy link
Contributor

130s commented Jun 2, 2014

Got it.

Restarted travis since 1 variant (out of 8) failed last time.

k-okada added a commit that referenced this pull request Jun 12, 2014
set hrpsys version greater than 315.2.0
@k-okada k-okada merged commit 2049f13 into start-jsk:master Jun 12, 2014
@k-okada k-okada deleted the hrpsys_version_gte branch June 12, 2014 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants