feat: Eliminate usage of OpenStruct #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
casperisfine
force-pushed
the
eliminate-open-struct
branch
from
72a5e26 to
c021666
Compare
seuros
approved these changes
Jan 22, 2024
seuros
reviewed
Jan 22, 2024
|
I will add testing in ruby 3.3 in another PR |
casperisfine
force-pushed
the
eliminate-open-struct
branch
from
c021666 to
0478ced
Compare
OpenStruct design cause it to have non-local performance impact, especially with JIT compilers. See ruby/ostruct#51 for full context, and it Ruby 3.3 OpenStruct usage raise a performance warnings: ``` gems/state_machines-audit_trail-2.0.2/lib/state_machines/audit_trail/transition_auditing.rb:38: warning: OpenStruct use is discouraged for performance reasons ``` In this case I don't really see any advantage of OpenStruct over a simple PORO.
casperisfine
force-pushed
the
eliminate-open-struct
branch
from
0478ced to
7cac29f
Compare
|
Alright, after adding a few more empty methods to comply to the I believe that strictly speaking this is backward compatible, since the initial transition accepting any possible method was AFAIK not documented. However it's not impossible some users may need to fix their code if they were wrongly calling methods outside of the interface. If we want to preserve backward compatibility for these projects, we can also define a |
seuros
changed the title
|
I will add the release workflow and merge this PR. |
|
Thank you very much 🙇 |
seuros
changed the title
|
released |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenStruct design cause it to have non-local performance impact, especially with JIT compilers.
See ruby/ostruct#51 for full context, and it Ruby 3.3 OpenStruct usage raise a performance warnings:
In this case I don't really see any advantage of OpenStruct over a simple PORO.
cc @seuros