-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1786 Adding real-to-real conversion builtin #2420
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2420 +/- ##
=======================================
Coverage 99.85% 99.85%
=======================================
Files 352 352
Lines 47299 47314 +15
=======================================
+ Hits 47230 47245 +15
Misses 69 69 ☔ View full report in Codecov by Sentry. |
LFRicIntXKern
, LFRicRealXKern
…Syclone into 1786_renaming_conversion_builtins
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! I have some requests on testing and documentation, and there are some style issues to fix (see inline).
Tests with compilation pass, the examples build and the user guide builds and displays nicely. The changes are covered. The branch also needs to be updated with the latest master.
src/psyclone/tests/domain/lfric/builtins/real_to_real_x_test.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there. There are some minor style and documentation changes to do.
Please also update the branch with the latest master if it changes before the next review round.
src/psyclone/tests/domain/lfric/builtins/real_to_real_x_test.py
Outdated
Show resolved
Hide resolved
src/psyclone/tests/domain/lfric/builtins/real_to_real_x_test.py
Outdated
Show resolved
Hide resolved
src/psyclone/tests/test_files/dynamo0p3/15.10.8_real_to_real_X_builtin.f90
Outdated
Show resolved
Hide resolved
…Syclone into 1786_renaming_conversion_builtins
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All well now. Updated changelog and user guide for merge to master. If CI and Integration tests pass, this can go on.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All well with the integration tests, proceeding to merge.
Closes part of #1786