2451 DynInvokeSchedule split & rename

[oakleybrunt]

closes #2451

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.85%. Comparing base (77510b9) to head (4164336).

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #2452   +/-   ##
=======================================
  Coverage   99.85%   99.85%           
=======================================
  Files         356      357    +1     
  Lines       47922    47929    +7     
=======================================
+ Hits        47853    47860    +7     
  Misses         69       69           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.86%. Comparing base (8ccdebe) to head (bf9d495).

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #2452   +/-   ##
=======================================
  Coverage   99.86%   99.86%           
=======================================
  Files         353      354    +1     
  Lines       48286    48293    +7     
=======================================
+ Hits        48223    48230    +7     
  Misses         63       63           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[oakleybrunt]

@TeranIvy - tests now passing, ready for review :)

[arporter]

Good job. I only managed to find one outstanding mention of DynInvokeSchedule:

./src/psyclone/tests/psyir/tools/call_tree_utils_test.py:    # This will return three schedule - the DynInvokeSchedule, and two

Ref. guide still builds fine, as does the UG. I'll fire off the integration tests but as these don't currently work for LFRic, I'll need independent verification from you that you tested this branch with LFRic :-)

[arporter]

All requested changes have been made (thanks) and integration tests were fine.
@oakleybrunt please could you confirm that you've tested LFRic with this branch?
Note: reference guide still builds fine.

[arporter]

@oakleybrunt, re. building with LFRic, Sergi is hopeful that he will have the integration tests fixed today so we can just wait for them to come back :-)

[oakleybrunt]

@oakleybrunt, re. building with LFRic, Sergi is hopeful that he will have the integration tests fixed today so we can just wait for them to come back :-)

Okay, I'll get Iva to run me through the process when she's back from leave for future reference :)

[arporter]

I've just triggered the integration tests. If they are OK then I'll proceed to merge.

[oakleybrunt]

I've just triggered the integration tests. If they are OK then I'll proceed to merge.

Thanks Andy, sorry for not getting to the LFRic testing myself.

[arporter]

Everything was green. will proceed to merge.

[arporter]

All good now.
Just waiting on final CI.