Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(towards 2004) Move same_range functionality to ArrayMixin and other improvements #2465

Merged
merged 10 commits into from
Feb 1, 2024

Conversation

sergisiso
Copy link
Collaborator

@sergisiso sergisiso commented Jan 11, 2024

This is some work in preparation of merging the two implementations we have of ArrayRange2Loop in #2004, but it is big enough to be a standalone PR:

  • It moves the same_range implementation outside the arrayrange transformation, because it seems this functionality is more generic.
  • It allows psyir_from_expression/statement methods to work without a symbol_table argument, because it is convenient for tests where we do not care about the symbol declarations.
  • It modernises method signatures using type hints
  • Adds some xfail test to demonstrate cases when this functionality is still lacking

@sergisiso sergisiso requested a review from arporter January 11, 2024 13:48
@sergisiso sergisiso self-assigned this Jan 11, 2024
Copy link

codecov bot commented Jan 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a8cd7b5) 99.85% compared to head (1bbf44b) 99.85%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2465      +/-   ##
==========================================
- Coverage   99.85%   99.85%   -0.01%     
==========================================
  Files         352      352              
  Lines       47338    47334       -4     
==========================================
- Hits        47269    47265       -4     
  Misses         69       69              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sergisiso sergisiso changed the title (towards 2004) Move same_range functionality and other improvements (towards 2004) Move same_range functionality to ArrayMixin and other improvements Jan 19, 2024
@sergisiso sergisiso requested a review from hiker January 19, 2024 15:45
@sergisiso
Copy link
Collaborator Author

This is now ready for review, one for @arporter or @hiker

@hiker hiker self-assigned this Jan 23, 2024
Copy link
Collaborator

@hiker hiker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job - I like the type annotations :) I had a question about the implementation, and otherwise mostly style issues.

@sergisiso
Copy link
Collaborator Author

@hiker This is ready for next review

@hiker
Copy link
Collaborator

hiker commented Jan 31, 2024

All good. Am waiting for CI to finish, then I'll merge it in

Copy link
Collaborator

@hiker hiker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is green, good to go.

@hiker hiker merged commit 699ceb2 into master Feb 1, 2024
11 of 12 checks passed
@hiker hiker deleted the 2004_move_same_range branch February 1, 2024 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants