-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(towards 2004) Move same_range functionality to ArrayMixin and other improvements #2465
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2465 +/- ##
==========================================
- Coverage 99.85% 99.85% -0.01%
==========================================
Files 352 352
Lines 47338 47334 -4
==========================================
- Hits 47269 47265 -4
Misses 69 69 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job - I like the type annotations :) I had a question about the implementation, and otherwise mostly style issues.
src/psyclone/tests/psyir/transformations/arrayrange2loop_trans_test.py
Outdated
Show resolved
Hide resolved
@hiker This is ready for next review |
All good. Am waiting for CI to finish, then I'll merge it in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI is green, good to go.
This is some work in preparation of merging the two implementations we have of ArrayRange2Loop in #2004, but it is big enough to be a standalone PR: