-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2773 add vernier support #2820
2773 add vernier support #2820
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2820 +/- ##
=======================================
Coverage 99.88% 99.88%
=======================================
Files 359 359
Lines 50258 50258
=======================================
Hits 50202 50202
Misses 56 56 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Joerg. It all looks fine. Just a few typos and I think the default directory name for the location of Vernier should be capitalised.
I've been unable to actually test the code yet as I can't build Vernier (see MetOffice/Vernier#154). I'll do that next time.
Ready for next review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for those changes and for helping me to get Vernier built.
I can now confirm I've built and run GOcean eg5 using the Vernier profiling.
I'll need to check the integration tests but this should be ready to go now.
The integration tests were all fine apart from NEMOv.4 which had a weird network error when attempting to upload performance results to mongoDB. Clearly not the fault of this PR. Therefore, I will bring this to master and proceed to merge. |
Adds a psydata wrapper and (gocean) example for using Vernier.