Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2773 add vernier support #2820

Merged
merged 10 commits into from
Jan 7, 2025
Merged

2773 add vernier support #2820

merged 10 commits into from
Jan 7, 2025

Conversation

hiker
Copy link
Collaborator

@hiker hiker commented Dec 9, 2024

Adds a psydata wrapper and (gocean) example for using Vernier.

Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.88%. Comparing base (9fe3a1d) to head (23385fc).
Report is 11 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2820   +/-   ##
=======================================
  Coverage   99.88%   99.88%           
=======================================
  Files         359      359           
  Lines       50258    50258           
=======================================
  Hits        50202    50202           
  Misses         56       56           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hiker hiker added the NG-ARCH Issues relevant to the GPU parallelisation of LFRic and other models expected to be used in NG-ARCH label Dec 17, 2024
Copy link
Member

@arporter arporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Joerg. It all looks fine. Just a few typos and I think the default directory name for the location of Vernier should be capitalised.
I've been unable to actually test the code yet as I can't build Vernier (see MetOffice/Vernier#154). I'll do that next time.

examples/gocean/eg5/profile/Makefile Show resolved Hide resolved
lib/profiling/README.md Outdated Show resolved Hide resolved
lib/profiling/vernier/Makefile Outdated Show resolved Hide resolved
lib/profiling/vernier/README.md Outdated Show resolved Hide resolved
lib/profiling/vernier/README.md Outdated Show resolved Hide resolved
lib/profiling/Makefile Outdated Show resolved Hide resolved
@hiker
Copy link
Collaborator Author

hiker commented Jan 6, 2025

Ready for next review.

Copy link
Member

@arporter arporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for those changes and for helping me to get Vernier built.
I can now confirm I've built and run GOcean eg5 using the Vernier profiling.
I'll need to check the integration tests but this should be ready to go now.

@arporter
Copy link
Member

arporter commented Jan 7, 2025

The integration tests were all fine apart from NEMOv.4 which had a weird network error when attempting to upload performance results to mongoDB. Clearly not the fault of this PR. Therefore, I will bring this to master and proceed to merge.

@arporter arporter merged commit 9b8a0ba into master Jan 7, 2025
13 checks passed
@arporter arporter deleted the 2773_add_vernier_support branch January 7, 2025 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NG-ARCH Issues relevant to the GPU parallelisation of LFRic and other models expected to be used in NG-ARCH ready to be merged under review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants