(Closes #2845) fix for inline symbol bug

[arporter]

No description provided.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.88%. Comparing base (2307ac7) to head (dbce296).

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #2848   +/-   ##
=======================================
  Coverage   99.88%   99.88%           
=======================================
  Files         359      359           
  Lines       50833    50833           
=======================================
  Hits        50777    50777           
  Misses         56       56           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[arporter]

A small change to the inlining transformation so that symbols are added to the table of the Routine of the call site rather than to the table of the local scope. This allows us to spot problems in the validate rather than crashing at the end of the appy() method. The integration tests will need to be run but I don't want to do that during the day while Glados is busy.

[LonelyCat124]

Need to check if the integration tests are ok, but the code changes all look fine, and tests/coverage/etc. are all fine.

Edit: Someone started the integration tests about 30 minutes ago - @arporter is this ok or do we need to stop them and try them later?

[arporter]

It's OK, it was me and I see NEMO v.4 failed :-(

[arporter]

Failure was:

  File "/home/gh_runner/actions-runner/_work/PSyclone-mirror/PSyclone-mirror/.runner_venv/lib/python3.13/site-packages/psyclone/psyir/symbols/symbol_table.py", line 1793, in rename_symbol
    raise ValueError(
        f"The symbol argument of rename_symbol() must belong to this "
        f"symbol_table instance, but '{symbol}' does not.")
ValueError: The symbol argument of rename_symbol() must belong to this symbol_table instance, but 'psyclone_cmp_int: DataSymbol<Scalar<BOOLEAN, UNDEFINED>, Automatic>' does not.
make: *** [Makefile:70: psycloned-openacc_kernels/dynldf.f90] Error 1

and must be because we are adding symbols to tables in nested scopes rather than the parent Routine scope.

[LonelyCat124]

Ok - I'll sent it back to you to resolve then

Integration tests failed

[arporter]

That was easier than I expected. Will wait until tonight to trigger integration tests again.

[arporter]

NEMO4 OpenACC kernels integration test failed again :-( Will investigate.

[arporter]

The failure is:

nemo4_src]$ psyclone -I ./ -s ~/PSyclone/examples/nemo/scripts/acc_kernels_trans.py nemogcm.f90

It is the inlining of nemo_init that causes the failure with a symbol that is unresolved in both the routine and, at the point of inlining, the call site:

psyclone.psyir.symbols.symbol.SymbolError: PSyclone SymbolTable error: A symbol named 'sn_ctl' is present but unresolved in one or both tables.