-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(Closes #2854) exclude char assignments from ACC KERNELS regions #2857
base: master
Are you sure you want to change the base?
Conversation
I'm not entirely happy with the code duplication here but this PR is for OpenACC functionality and the existing check is in the conversion of array assignments to loops so there's not much common ground between them. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2857 +/- ##
=======================================
Coverage 99.88% 99.88%
=======================================
Files 359 359
Lines 50833 50847 +14
=======================================
+ Hits 50777 50791 +14
Misses 56 56 ☔ View full report in Codecov by Sentry. |
I've solved the duplication by making the validation a separate classmethod in ArrayAssignment2LoopsTrans. Coverage is 100%. I'll set the integration tests running. |
Integration test for NEMOv4 failed but only because of a small bug where we failed to lower-case the name of a structure component when getting its datatype. I'll re-run that job. |
Integration tests now green. Ready for review from anyone :-) |
I changed my mind - it turns out my 'fix' revealed general case-sensitivity problems in our storage of components of a StructureType. I've fixed these now and extended the tests slightly. |
Small PR that picks up the functionality already in ArrayAssignment2LoopsTrans and copies it into ACCKernelsTrans.