Promote dev capi changes to staging #262
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fully create upgraded worker node before deleting old one. Allows things like longhorn volumes to migrate better
promote all dev changes to capi-infra chart to staging
bump to 1.7.1 tweaks to values to what they were expected
anish-mudaraddi
force-pushed
the
promote-capi-staging
branch
from
e3e5043 to
213b13c
Compare
DavidFair
requested changes
Jan 16, 2025
Comment on lines
+8
to
10
| machineCount: 3 | ||
| machineFlavor: l3.micro | ||
|
|
There was a problem hiding this comment.
Could we use the dep-l2 flavours as l3 is quite tight?
Comment on lines
+3
to
+4
| controlPlane: | ||
| machineCount: 3 |
There was a problem hiding this comment.
Could this be left implicit at 5, since this means we cannot lose 2 members without a full rebuild, so trying to recover becomes scarier than losing 1 and having another to start recovery from
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
promote all dev changes to capi-infra chart to staging