-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hv placement switch #9
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9 +/- ##
==========================================
- Coverage 99.55% 98.76% -0.80%
==========================================
Files 111 115 +4
Lines 4244 4282 +38
==========================================
+ Hits 4225 4229 +4
- Misses 19 53 +34 ☔ View full report in Codecov by Sentry. |
8a896d9
to
196e886
Compare
These resources all return None for HVs, as Yoga+ expects us to use a resource object instead. Remove these since they will not work again, and any downstream usage will fail loudly when they try to import the dead enum. This will require a major version bump which will come in the next commit adding the placement replacement.
196e886
to
5ce00c8
Compare
In Yoga+ placement should be used for determining usage...etc. with Horizon having switched to it upstream. Unfortunately, we don't have full support in the latest SDK for getting usage, so add some static methods and data classes to support this until we/someone else upstream the work.
Update author to reflect entire group and bump to v1 with latest breaking changes removing various HV presets
5ce00c8
to
7e80e57
Compare
Questions for draft feedback:
|
I think it depends on whether we will add more features that interact with the Placement API in the future. If there are other features we want to add that will interact with Placement, then calling it Placement* would be okay. However if we are only going to be interacting with this specific part of the API we should call it something else. |
The switch to using the placement api for hypervisor resource usage was made in #1 which fixed the missing resource fields and was implemented so it was backwards compatible with the hypervisor query. After investigating the issue I think you were having with the find empty hypervisor stackstorm action there was a missing catch for KeyError in the client side filter handler when the resource is not found as is the case for ironic hypervisors. |
Hypervisor
, as these are deprecated and return NoneHypervisorQuery
TODO pending draft feedback:
Testing