Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revise: relax CommentWhitespace lint #314

Merged
merged 3 commits into from
Jan 24, 2025
Merged

Conversation

a-frantz
Copy link
Member

@a-frantz a-frantz commented Jan 24, 2025

This pull request adds modifies a new rule to wdl-lint.

  • Rule Name: CommentWhitespace

Describe the rules you have implemented and link to any relevant issues.

Relaxes CommentWhitespace to fix #313

Before submitting this PR, please make sure:

  • You have added a few sentences describing the PR here.
  • You have added yourself or the appropriate individual as the assignee.
  • You have added at least one relevant code reviewer to the PR.
  • Your code builds clean without any errors or warnings.
  • You have added an entry to the relevant CHANGELOG.md (see
    "keep a changelog" for more information).
  • Your commit messages follow the conventional commit style.

Rule specific checks:

  • You have added the rule as an entry within RULES.md.
  • You have added the rule to the rules() function in wdl-lint/src/lib.rs.
  • You have added a test case in wdl-lint/tests/lints that covers every
    possible diagnostic emitted for the rule within the file where the rule
    is implemented.
  • If you have implemented a new Visitor callback, you have also
    overridden that callback method for the special Validator
    (wdl-ast/src/validation.rs) and LintVisitor
    (wdl-lint/src/visitor.rs) visitors. These are required to ensure the new
    visitor callback will execute.
  • You have run wdl-gauntlet --refresh to ensure that there are no
    unintended changes to the baseline configuration file (Gauntlet.toml).
  • You have run wdl-gauntlet --refresh --arena to ensure that all of the
    rules added/removed are now reflected in the baseline configuration file
    (Arena.toml).

@a-frantz a-frantz self-assigned this Jan 24, 2025
@a-frantz a-frantz marked this pull request as ready for review January 24, 2025 19:58
@a-frantz a-frantz merged commit 896981f into main Jan 24, 2025
16 checks passed
@a-frantz a-frantz deleted the revise/CommentWhitespace branch January 24, 2025 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

relax CommentWhitespace lint
2 participants