New unit tests for Strict mode using JSONTokener and JSONParserConfiguration

[Simulant87]

Adding new test cases with invalid characters at th end of the input to validate that the strict mode is enforced by the constructors of JSONObject and JSONArray. Turns out, that the constructor with JSONTokener instead of String input does not enforce the strict mode at the end of the object creation.

demonstrating, but not fixing, the bug behavior described in #935

[stleary]

Unit tests are failing, was this tested locally before committing?

[Simulant87]

The PR is not intended to be merged right away, while still having a complete green test result. So the currently failing behavior of 2 out of 4 provided tests is intended to demonstrate the current bug behavior and describe the expected behavior after a fix, which I haven't provided.

I provided 2 tests each for JSONObject and JSONArray. Each with the same String input to parse a valid Object/Array, followed by additional invalid parameters and having the strict mode enabled. So all tests are expected to throw an exception, because of the strict mode enabled and the invalid characters at end.
The plain String input works as expected, while the same String input wrapped by a JSONTokener doees not throw the expected exception. This is demonstrated by this PR.

I did not provide a fix for this bug. I tried adding this kind of check here. Although it makes my provided failing test green, it lead to other existing tests to fail, where nested Objects are parsed. As at the end of the nested object, the following characters for the outer object are matched incorrectly eagerly as invalid content following the nested object. To fix this I assume the JSONTokener should carry some kind of nesting/indent-level information, which has to be check as well and the check should only be applied at the outer most Object/Array level.

[stleary]

I think I understand what you are saying. However, the unit tests failures are hidden behind unknown symbol errors, because you did not include this line in JSONParserConfigurationTest.java:

import org.json.JSONTokener;

[Simulant87]

right, I forgot to push the missing import. should be fixed now.

[stleary]

@Simulant87 These are good tests, but 2 of them will need to be updated to match actual exception messages, after #937 is merged

[Simulant87]

Thank you, I could update them after #937 is merged, or as an alternative I integrated everything togher in #938

[Simulant87]

This PR should be closed in favour of #938 (when that one is merged).

[stleary]

Closed due to issue resolved in another commit