-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replaced ping setInterval integration with webworker #579
base: develop
Are you sure you want to change the base?
Conversation
This does look interesting and useful. A couple of feedback:
Please only commit changes to the src folder. Makes it easier to review and compare. |
Many thanks! The code looks beautiful. Please allow me a few days to review this. I may have a few suggestions - those will be optional. In addition, if possible, we should figure out to include it as part of the tests as well. |
Thanks for the review. Again, i fixed some minor issues. Tests should be running now. |
Will release as pert of v7.1 |
Hi! sorry to ask, do you have an estimated ETA for v7.1? can't find that info, and this would be great to finally resolve the issue about timers throttled in chrome. Thanks! |
Hi, does anyone know when v7.1 will be released. Sorry if this question makes anyone uncomfortable. Greetings. |
Please refrain from asking for the release (and for anything else for that matter), as it will:
|
I think this is not a good solution to add webworker, rememeber webworker will be created for each tab. |
d283030
to
3314fc2
Compare
The use of setInterval can be paused by the OS as soon as the browser tab or mobile browser app is in the background. Due to this behavior, the Stomp client library no longer sends ping messages and the Stomp server will close the connection. By using a webworker, the affected code will continue to run and ping-messages will be sent, even if the tab/app is not active.