Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement selection of which templates to serve from S3 #5

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

thiagofigueiro
Copy link

This allows you to do something like this in s3_rails.yml:

  include_list: ['reports/yearly_report.pdf.prawn', 'reports/monthly_report.pdf.prawn']

It's a fairly quick-and-dirty implementation that I did on a pinch to get me going with a project at work.

If someone has some time it would be nice to:

  • Add tests.
  • Implement the filter when fetching S3 objects (load_cache) instead of when looking-up cache (query).

@thiagofigueiro
Copy link
Author

Hey, @straydogstudio - sorry about that dud PR yesterday.

This one is working as expected, even thought I'm not super confident in how I implemented it. In any case, it's here for using or throwing away as you see fit.

Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant