Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix console #1198

Merged
merged 2 commits into from
Dec 29, 2024
Merged

Fix console #1198

merged 2 commits into from
Dec 29, 2024

Conversation

ericsyh
Copy link
Member

@ericsyh ericsyh commented Dec 24, 2024

(If this PR fixes a github issue, please add Fixes #<xyz>.)

Fixes

(or if this PR is one task of a github issue, please add Master Issue: #<xyz> to link to the master issue.)

Master Issue: #

Motivation

Fix the issue involed from the PR #1191

Modifications

Describe the modifications you've done.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Documentation

Check the box below.

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

@ericsyh ericsyh requested review from a team as code owners December 24, 2024 05:17
@github-actions github-actions bot added the no-need-doc This pr does not need any document label Dec 24, 2024
@ericsyh
Copy link
Member Author

ericsyh commented Dec 24, 2024

validation yaml

components:
  pulsar_coordinator: true

monitoring:
  # monitoring - prometheus
  prometheus: false
  # monitoring - grafana
  grafana: false

auth:
  authentication:
    enabled: true
    provider: "jwt"
    jwt:
      enabled: true
      # Enable JWT authentication
      # If the token is generated by a secret key, set the usingSecretKey as true.
      # If the token is generated by a private key, set the usingSecretKey as false.
      usingSecretKey: true
      # Whether to enable automatic initialization jwt authentication secret
      autoInitSecret: true
  authorization:
    enabled: true

zookeeper:
  replicaCount: 1

bookkeeper:
  replicaCount: 1

broker:
  configData:
    managedLedgerDefaultEnsembleSize: "1"
    managedLedgerDefaultWriteQuorum: "1"
    managedLedgerDefaultAckQuorum: "1"

streamnative_console:
  login:
    sso:
      pulsarJwt:
        enabled: true
        config:
          AUTHENTICATION_CUSTOM_CLAIM: sub
          # The secret should contain both `TOKEN`
          SERVICE_ACCOUNT_SUPER_TOKEN_SECRET: "snp-token-pulsar-manager-admin"
          # AUTH_METHOD_CUSTOM_CLAIM: sub
          # USERNAME_CLAIM: sub
          JWT_BROKER_TOKEN_MODE: SECRET
          # The secret should contain both `PUBLICKEY`, `PRIVATEKEY`
          JWT_BROKER_PUBLIC_PRIVATE_KEY: ""
          # The secret should contain both `SECRETKEY`
          JWT_BROKER_SECRET_KEY: "snp-token-symmetric-key"
          JWT_BROKER_SECRET_KEY_FILE: "token/secret.key"

install the yaml by

helm install snp -f jwt.yaml charts/charts/sn-platform-slim -n snp

@ericsyh ericsyh merged commit d6e5e2d into master Dec 29, 2024
3 checks passed
@ericsyh ericsyh deleted the fix-console branch December 29, 2024 15:58
ericsyh added a commit that referenced this pull request Dec 30, 2024
<!--
### Contribution Checklist

- Name the pull request in the form "[charts/<chart-name>] Title of the
pull request".
Skip *[charts/<chart-name>]* if the PR doesn't change a specific chart.
E.g. `[docs] Fix typo in README`.

- Fill out the template below to describe the changes contributed by the
pull request. That will give reviewers the context they need to do the
review.

- Each pull request should address only one issue, not mix up code from
multiple issues.

  - Each commit in the pull request has a meaningful commit message

- Once all items of the checklist are addressed, remove the above text
and this checklist, leaving only the filled out template below.

**(The sections below can be removed for hotfixes of typos)**
-->

*(If this PR fixes a github issue, please add `Fixes #<xyz>`.)*

Fixes

*(or if this PR is one task of a github issue, please add `Master Issue:
#<xyz>` to link to the master issue.)*

Master Issue: #<xyz>

### Motivation

Fix the issue involed from the PR
#1191

### Modifications

*Describe the modifications you've done.*

### Verifying this change

- [ ] Make sure that the change passes the CI checks.

*(Please pick either of the following options)*

This change is a trivial rework / code cleanup without any test
coverage.

*(or)*

This change is already covered by existing tests, such as *(please
describe tests)*.

*(or)*

This change added tests and can be verified as follows:

*(example:)*
- *Added integration tests for end-to-end deployment with large payloads
(10MB)*
  - *Extended integration test for recovery after broker failure*

### Documentation

Check the box below.

Need to update docs?

- [ ] `doc-required`

  (If you need help on updating docs, create a doc issue)

- [x] `no-need-doc`

  (Please explain why)

- [ ] `doc`

  (If this PR contains doc changes)

---------

Signed-off-by: ericsyh <[email protected]>
(cherry picked from commit d6e5e2d)
ericsyh added a commit that referenced this pull request Dec 30, 2024
<!--
### Contribution Checklist

- Name the pull request in the form "[charts/<chart-name>] Title of the
pull request".
Skip *[charts/<chart-name>]* if the PR doesn't change a specific chart.
E.g. `[docs] Fix typo in README`.

- Fill out the template below to describe the changes contributed by the
pull request. That will give reviewers the context they need to do the
review.

- Each pull request should address only one issue, not mix up code from
multiple issues.

  - Each commit in the pull request has a meaningful commit message

- Once all items of the checklist are addressed, remove the above text
and this checklist, leaving only the filled out template below.

**(The sections below can be removed for hotfixes of typos)**
-->

*(If this PR fixes a github issue, please add `Fixes #<xyz>`.)*

Fixes

*(or if this PR is one task of a github issue, please add `Master Issue:
#<xyz>` to link to the master issue.)*

Master Issue: #<xyz>

### Motivation

Fix the issue involed from the PR
#1191

### Modifications

*Describe the modifications you've done.*

### Verifying this change

- [ ] Make sure that the change passes the CI checks.

*(Please pick either of the following options)*

This change is a trivial rework / code cleanup without any test
coverage.

*(or)*

This change is already covered by existing tests, such as *(please
describe tests)*.

*(or)*

This change added tests and can be verified as follows:

*(example:)*
- *Added integration tests for end-to-end deployment with large payloads
(10MB)*
  - *Extended integration test for recovery after broker failure*

### Documentation

Check the box below.

Need to update docs?

- [ ] `doc-required`

  (If you need help on updating docs, create a doc issue)

- [x] `no-need-doc`

  (Please explain why)

- [ ] `doc`

  (If this PR contains doc changes)

---------

Signed-off-by: ericsyh <[email protected]>
(cherry picked from commit d6e5e2d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-need-doc This pr does not need any document
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants