[FC] Adds ActivityRetainedScope and broader singleton component

[carlosmuvi-stripe]

Summary

Today, we're using the @Singleton dagger scope wrongly, as dependencies are not shared across activities or match the app's lifecycle (see docs).

This PR replaces current Singleton scope usages by ActivityRetainedScope, that clearly defines the real scope of existing dependencies.

Additionally, this PR includes a way to share dependencies across activities (real @Singleton scope), by defining a thread-safe singleton pattern for SharedComponentHolder to manage shared dependencies (e.g., Play Integrity API) across activities.

Motivation

We're preparing the ground to share the Integrity component across activities.

The idea is to call Integrity#prepare on Activity A (FinancialConnectionsSheetActivity) and reuse the same Integrity instance in Activity B (FinancialConnectionsNativeActivity) when generating tokens.

Took the opportunity to fix our current scope setup.

Testing

• Added tests
• Modified tests
• Manually verified

[carlosmuvi-stripe]

• [FC] Adds attestation analytics events. #9831
• [FC] Add app verification to signup flows (Networking+ID) #9830
• [FC] Updates lookup call to use mobile endpoint on verified flows #9820
• [FC] Sends supports_app_verification to sync call when Integrity available #9819
• [FC] Prepares integrity on first sync call #9818
• [FC] Adds ActivityRetainedScope and broader singleton component #9821 👈 (View in Graphite)
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

[github-actions]

Diffuse output:

OLD: identity-example-release-base.apk (signature: V1, V2)
NEW: identity-example-release-pr.apk (signature: V1, V2)

          │          compressed          │         uncompressed         
          ├───────────┬───────────┬──────┼───────────┬───────────┬──────
 APK      │ old       │ new       │ diff │ old       │ new       │ diff 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
      dex │     2 MiB │     2 MiB │  0 B │   4.1 MiB │   4.1 MiB │  0 B 
     arsc │     1 MiB │     1 MiB │  0 B │     1 MiB │     1 MiB │  0 B 
 manifest │   2.3 KiB │   2.3 KiB │  0 B │     8 KiB │     8 KiB │  0 B 
      res │ 301.8 KiB │ 301.8 KiB │  0 B │ 455.5 KiB │ 455.5 KiB │  0 B 
   native │   6.2 MiB │   6.2 MiB │  0 B │  15.8 MiB │  15.8 MiB │  0 B 
    asset │   7.1 KiB │   7.1 KiB │  0 B │   6.9 KiB │   6.9 KiB │  0 B 
    other │  90.2 KiB │  90.2 KiB │ +3 B │ 170.3 KiB │ 170.3 KiB │  0 B 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
    total │   9.6 MiB │   9.6 MiB │ +3 B │  21.5 MiB │  21.5 MiB │  0 B 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 19971 │ 19971 │ 0 (+0 -0) 
   types │  6191 │  6191 │ 0 (+0 -0) 
 classes │  4982 │  4982 │ 0 (+0 -0) 
 methods │ 29772 │ 29772 │ 0 (+0 -0) 
  fields │ 17542 │ 17542 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  164 │  164 │  0   
 entries │ 3622 │ 3622 │  0

APK

   compressed    │   uncompressed   │                                           
──────────┬──────┼───────────┬──────┤                                           
 size     │ diff │ size      │ diff │ path                                      
──────────┼──────┼───────────┼──────┼───────────────────────────────────────────
 28.5 KiB │ +3 B │  62.9 KiB │  0 B │ ∆ META-INF/CERT.SF                        
 25.3 KiB │ +3 B │  62.8 KiB │  0 B │ ∆ META-INF/MANIFEST.MF                    
  1.2 KiB │ -2 B │   1.2 KiB │  0 B │ ∆ META-INF/CERT.RSA                       
    271 B │ -1 B │     120 B │  0 B │ ∆ META-INF/version-control-info.textproto 
──────────┼──────┼───────────┼──────┼───────────────────────────────────────────
 55.2 KiB │ +3 B │ 127.1 KiB │  0 B │ (total)

[carlosmuvi-stripe]

We'll be adding the integrity manager here later in this stack.

[carlosmuvi-stripe]

Note that, given the new component structure, there's no room for mistakenly scoping a dependency as @singleton on a non shared component. Dagger would fail at compile time if one of these (or other module) dependencies are scoped as @singleton.

[tillh-stripe]

Nit: This could use Component.Factory.

[carlosmuvi-stripe]

Merge activity

• Jan 10, 12:33 PM EST: A user merged this pull request with Graphite.