Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FormActivityViewModel #9946

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from
Draft

Conversation

tjclawson-stripe
Copy link
Collaborator

@tjclawson-stripe tjclawson-stripe commented Jan 21, 2025

Summary

Add FormActivityViewModel with DefaultFormInteractor to display FormUI on FormActivity

Will rebase once 9919 is merged

Motivation

MOBILESDK-2941

Testing

  • Added tests
  • Modified tests
  • Manually verified
Screen.Recording.2025-01-21.at.11.42.31.AM.mov

Changelog

@tjclawson-stripe tjclawson-stripe changed the base branch from master to tyler/mobilesdk-2940 January 21, 2025 16:43
@tjclawson-stripe tjclawson-stripe marked this pull request as ready for review January 21, 2025 16:44
@tjclawson-stripe tjclawson-stripe requested review from a team as code owners January 21, 2025 16:44
@tjclawson-stripe tjclawson-stripe requested review from cttsai-stripe and removed request for a team January 21, 2025 16:44
viewModel.initializeFormInteractor(
metadata,
args.selectedPaymentMethodCode,
)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I update to use AssistedInjection?

@Singleton
@Component(
modules = [
SharedPaymentElementViewModelModule::class,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I create a module for FormActivityViewModel or is re-using SharedPaymentElementViewModelModule acceptable?

Copy link
Contributor

github-actions bot commented Jan 21, 2025

Diffuse output:

OLD: identity-example-release-base.apk (signature: V1, V2)
NEW: identity-example-release-pr.apk (signature: V1, V2)

          │          compressed          │         uncompressed         
          ├───────────┬───────────┬──────┼───────────┬───────────┬──────
 APK      │ old       │ new       │ diff │ old       │ new       │ diff 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
      dex │     2 MiB │     2 MiB │  0 B │   4.1 MiB │   4.1 MiB │  0 B 
     arsc │     1 MiB │     1 MiB │  0 B │     1 MiB │     1 MiB │  0 B 
 manifest │   2.3 KiB │   2.3 KiB │  0 B │     8 KiB │     8 KiB │  0 B 
      res │ 302.6 KiB │ 302.6 KiB │  0 B │ 456.7 KiB │ 456.7 KiB │  0 B 
   native │   6.2 MiB │   6.2 MiB │  0 B │  15.8 MiB │  15.8 MiB │  0 B 
    asset │   7.2 KiB │   7.2 KiB │  0 B │   6.9 KiB │   6.9 KiB │  0 B 
    other │  90.4 KiB │  90.4 KiB │ -2 B │ 170.7 KiB │ 170.7 KiB │  0 B 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
    total │   9.6 MiB │   9.6 MiB │ -2 B │  21.5 MiB │  21.5 MiB │  0 B 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 19982 │ 19982 │ 0 (+0 -0) 
   types │  6194 │  6194 │ 0 (+0 -0) 
 classes │  4985 │  4985 │ 0 (+0 -0) 
 methods │ 29820 │ 29820 │ 0 (+0 -0) 
  fields │ 17539 │ 17539 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  164 │  164 │  0   
 entries │ 3624 │ 3624 │  0
APK
   compressed    │   uncompressed   │                        
──────────┬──────┼───────────┬──────┤                        
 size     │ diff │ size      │ diff │ path                   
──────────┼──────┼───────────┼──────┼────────────────────────
 25.4 KiB │ -6 B │    63 KiB │  0 B │ ∆ META-INF/MANIFEST.MF 
 28.5 KiB │ +4 B │  63.1 KiB │  0 B │ ∆ META-INF/CERT.SF     
──────────┼──────┼───────────┼──────┼────────────────────────
 53.9 KiB │ -2 B │ 126.1 KiB │  0 B │ (total)

Base automatically changed from tyler/mobilesdk-2940 to master January 22, 2025 14:04
@tjclawson-stripe tjclawson-stripe marked this pull request as draft January 22, 2025 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant