Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix textEncoder missing issue #11

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Fix textEncoder missing issue #11

merged 1 commit into from
Jan 14, 2025

Conversation

jiqiang90
Copy link
Collaborator

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #10

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • I have tested locally
  • I have performed a self review of my changes
  • Updated any relevant documentation
  • Linked to any relevant issues
  • I have added tests relevant to my changes
  • Any dependent changes have been merged and published in downstream modules
  • My code is up to date with the base branch
  • I have updated relevant changelogs. We suggest using chan

@jiqiang90 jiqiang90 merged commit 7441806 into main Jan 14, 2025
2 of 3 checks passed
@ianhe8x ianhe8x deleted the fix-textEncoder-missing branch January 14, 2025 03:06
Copy link

Coverage report

Caution

Test run failed

St.
Category Percentage Covered / Total
🔴 Statements 40.64% 1875/4614
🟡 Branches 65.98% 192/291
🔴 Functions 51.05% 97/190
🔴 Lines 40.64% 1875/4614

Test suite run failed

Failed tests: 1/39. Failed suites: 1/9.
  ● Codegen spec › validate Abi.json path field

    expect(received).rejects.toThrow(expected)

    Expected pattern: /Asset: "zkLend" not found in project/
    Received message: "Error: Asset zkLend, file ./abis/xxx.json does not exist"

          127 |     const filePath = path.join(projectPath, value.file);
          128 |     if (!fs.existsSync(filePath)) {
        > 129 |       throw new Error(`Error: Asset ${name}, file ${value.file} does not exist`);
              |             ^
          130 |     }
          131 |     // We use actual abi file name instead on name provided in assets
          132 |     // This is aligning with files in './ethers-contracts'

      at addAsset (packages/common-starknet/src/codegen/codegen-controller.ts:129:13)
      at prepareSortedAssets (packages/common-starknet/src/codegen/codegen-controller.ts:141:7)
      at generateAbis (packages/common-starknet/src/codegen/codegen-controller.ts:234:24)
      at Object.<anonymous> (packages/common-starknet/src/codegen/codegen-controller.spec.ts:40:19)
      at Object.toThrow (node_modules/expect/build/index.js:210:22)
      at Object.<anonymous> (packages/common-starknet/src/codegen/codegen-controller.spec.ts:41:15)

Report generated by 🧪jest coverage report action from 546f5fb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing TextEncoder from sandbox
2 participants