-
Notifications
You must be signed in to change notification settings - Fork 913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use nginx to proxy browser request to collaboration-server service. #4225
base: test-collab
Are you sure you want to change the base?
Conversation
Haven't tested this yet, I don't remember us agreeing to have an nginx service running together with other services. |
nginx is an easy way to do this... any down side? |
Yes, nginx is an easy way to do this, but we'll have one configuration on the server so we can run multiple containers and have it direct traffic where we want it to, having it as part of the services means any number of containers we decide to run will have their own configuration and that's not a great way to do this. |
@chimosky I agree with you. In fact, I tried multiple ways to avoid using anything like Nginx. The problem is that we are trying to access the To my knowledge, we'll have to port map If you have a better workaround for it other than using nginx, please let me know. I'd be happy to make the changes. |
I noticed the issue with this earlier, couldn't figure out why and a possible solution, haven't tested your changes yet and I will. If it fixes the issue then we can go with it, this would mean that the gateway to the services would be nginx and we can live with that. |
Yeah, I guess, we should go with this solution for now until we find a better one. Please test to your side whenever you get a chance and let me know your thoughts. |
Tested your changes, it doesn't work as expected. Musicblocks runs, but I don't get a prompt about collaboration, the npm error Missing script: "server"
npm error
npm error Did you mean this?
npm error npm run serve # run the "serve" package script
npm error
npm error To see a list of scripts, run:
npm error npm run
npm error A complete log of this run can be found in: /root/.npm/_logs/2025-01-09T17_16_06_540Z-debug-0.log |
@chimosky I have commented out the previous code for now (to keep it just in case I need it later) but once I get your input on these new configurations, I'll clean things up.