Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

todo: apply array destructuring #4232

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

retrogtx
Copy link
Contributor

@retrogtx retrogtx commented Jan 6, 2025

Completed the given Todo:

// TODO: make this an array this._expandX = w; this._expandY = h; this._expandX2 = w2; this._expandY2 = h2;

The contents are now inside an array

@walterbender
Copy link
Member

How did you test this? Did you also change wherever the method is called? It does not work for me.

@retrogtx
Copy link
Contributor Author

retrogtx commented Jan 9, 2025

How did you test this? Did you also change wherever the method is called? It does not work for me.

I ran musicblocks locally and used boolean blocks that seems to use this, it worked
I will have to look if other parts use the same code too, on it. Thought that I would need to change the array only.

What issue are you facing btw, like does the app not run? Thank you

@walterbender
Copy link
Member

I will try testing again. MB would not start on your branch in my previous tests.

@retrogtx
Copy link
Contributor Author

retrogtx commented Jan 9, 2025

Now that's really odd.

I still haven't made any other change right now, but it still works on my side.

Please let me know if this one works!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants