Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark mode #4244

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Dark mode #4244

wants to merge 2 commits into from

Conversation

Commanderk3
Copy link
Contributor

[Work in Progress]

I just want to make sure that whether this approach is good or not. Many of the colors in MB are derived from platformstyle.js
Modifying this file will require less hardcoding to change the theme to dark mode. When you toggle to dark mode the user has to reload the website to observe the changes. This is similar to how changing of languages works. With this PR, the isDarkModeON is stored locally (like beginnerMode). When the website starts it checks if isDarkModeON is true, if yes then it initializes a different set of colors (in platformstyle.js)
Of course there are some elements whose color is not defined by platformstyle.js . For them I guess we can define there color specifically.

@walterbender What do you think ?

The colors for dark mode can be better I guess.....

d1

d2

@walterbender
Copy link
Member

Mostly kind of works. The palette buttons should prob. not change to black on blue. The palette background should not be white. The block colors themselves should probably be adjusted, esp. if the label text is now white.

@Commanderk3
Copy link
Contributor Author

Mostly kind of works. The palette buttons should prob. not change to black on blue. The palette background should not be white. The block colors themselves should probably be adjusted, esp. if the label text is now white.

Noted 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants