Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Work in Progress]
I just want to make sure that whether this approach is good or not. Many of the colors in MB are derived from platformstyle.js
Modifying this file will require less hardcoding to change the theme to dark mode. When you toggle to dark mode the user has to reload the website to observe the changes. This is similar to how changing of languages works. With this PR, the isDarkModeON is stored locally (like beginnerMode). When the website starts it checks if isDarkModeON is true, if yes then it initializes a different set of colors (in platformstyle.js)
Of course there are some elements whose color is not defined by platformstyle.js . For them I guess we can define there color specifically.
@walterbender What do you think ?
The colors for dark mode can be better I guess.....