Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Logo Alignment Issue in Japanese Language Interface #4270

Merged
merged 2 commits into from
Jan 18, 2025

Conversation

iampratt
Copy link
Contributor

Description

This PR addresses the logo alignment issue in the Japanese language interface. The previous alignment was inconsistent with other UI elements, causing a lack of visual balance. The updated code ensures proper alignment and consistent spacing, enhancing the interface’s overall appearance.

Related Issue

This PR fixes #4269

Screenshots

Before fix-
Screenshot 2025-01-14 at 11 48 18

After fix-
Screenshot 2025-01-14 at 12 08 30

Changes Made

  • Adjusted the logo’s vertical alignment in the index.html file.
  • Ensured consistent spacing between the logo and adjacent elements.

Testing Performed

The fix has been tested on:

  • OS: Windows, Mac, Linux
  • Browsers: Chrome, Firefox, Safari
  • Language setting: Japanese

Checklist

  • I have tested these changes locally and they work as expected.
  • I have followed the project's coding style guidelines.

@FirePheonix
Copy link
Contributor

i was working on japanese logos and loading screen in PR #4266.
I realized that Japanese language has both Japanese + Kana-Japanese writing systems. Just make sure this change is applied in both cases brother.

@iampratt
Copy link
Contributor Author

@FirePheonix Thanks for pointing that out! I checked personally, and the fix applies to both Japanese writing systems. Everything is working perfectly on my end. Let me know if you spot anything else!

@iampratt
Copy link
Contributor Author

@walterbender I just wanted to see if you’ve had a chance to review this PR. If you notice anything that needs to be changed, please let me know. Thanks!

@walterbender walterbender merged commit 5ac4fdc into sugarlabs:master Jan 18, 2025
@iampratt iampratt deleted the fix_japanese_logo branch January 19, 2025 04:52
Ubayed-Bin-Sufian pushed a commit to Ubayed-Bin-Sufian/musicblocks that referenced this pull request Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logo Alignment Issue in Japanese Language Interface
3 participants