Skip to content
This repository has been archived by the owner on May 28, 2024. It is now read-only.

deal with another alternate orcid format for contributors #1059

Merged
merged 2 commits into from
Nov 15, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/services/orcid_builder.rb
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,6 @@ def orcidid(contributor)
return identifier.uri if identifier.uri
return identifier.value if identifier.value.start_with?('https://orcid.org/')

URI.join(identifier.source.uri, identifier.value).to_s
URI.join('https://orcid.org/', identifier.value).to_s
end
end
2 changes: 1 addition & 1 deletion spec/indexers/descriptive_metadata_indexer_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@
],
identifier: [
{
value: 'https://orcid.org/0000-0001-5321-289X',
value: '0000-0001-5321-289X',
type: 'ORCID',
source: {
code: 'orcid'
Expand Down