Fix unit tests

sulu · Jul 16, 2024 · 322364c · 322364c
1 parent e39eadb
commit 322364c
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 3 deletions.
diff --git a/Document/Subscriber/RoutableSubscriber.php b/Document/Subscriber/RoutableSubscriber.php
@@ -401,7 +401,7 @@ private function getRoutePathPropertyName(string $structureType, string $locale)
     {
         $metadata = $this->metadataFactory->getStructureMetadata('article', $structureType);
 
-        if ($metadata->hasPropertyWithTagName(self::TAG_NAME)) {
+        if ($metadata->hasTag(self::TAG_NAME)) {
             return $this->getPropertyName($locale, $metadata->getPropertyByTagName(self::TAG_NAME)->getName());
         }
 

diff --git a/Resources/phpcr-migrations/Version202407111600.php b/Resources/phpcr-migrations/Version202407111600.php
@@ -21,7 +21,6 @@
 use Sulu\Component\Localization\Localization;
 use Symfony\Component\DependencyInjection\ContainerInterface;
 
-
 class Version202407111600 implements VersionInterface, ContainerAwareInterface
 {
     /**

diff --git a/Tests/Application/Kernel.php b/Tests/Application/Kernel.php
@@ -39,7 +39,7 @@ public function registerBundles(): iterable
         return $bundles;
     }
 
-    public function registerContainerConfiguration(LoaderInterface $loader)
+    public function registerContainerConfiguration(LoaderInterface $loader): void
     {
         parent::registerContainerConfiguration($loader);
 

diff --git a/Tests/Unit/Document/Subscriber/RoutableSubscriberTest.php b/Tests/Unit/Document/Subscriber/RoutableSubscriberTest.php
@@ -159,6 +159,7 @@ public function testHandlePersist()
 
         $this->metadataFactory->getStructureMetadata('article', 'default')->willReturn($metadata->reveal());
         $this->propertyEncoder->localizedSystemName('routePath', 'de')->willReturn('i18n:de-routePath');
+        $this->propertyEncoder->localizedContentName('routePathName', 'de')->willReturn('i18n:de-routePathName');
 
         $children = [
             $this->prophesize(RoutablePageBehavior::class),
@@ -200,8 +201,11 @@ public function testHandlePersist()
         $children[2]->setRoutePath('/test-3')->shouldBeCalled();
 
         $nodes[0]->setProperty('i18n:de-routePath', '/test-1')->shouldBeCalled();
+        $nodes[0]->setProperty('i18n:de-routePathName', 'i18n:de-routePath')->shouldBeCalled();
         $nodes[1]->setProperty('i18n:de-routePath', '/test-2')->shouldBeCalled();
+        $nodes[1]->setProperty('i18n:de-routePathName', 'i18n:de-routePath')->shouldBeCalled();
         $nodes[2]->setProperty('i18n:de-routePath', '/test-3')->shouldBeCalled();
+        $nodes[2]->setProperty('i18n:de-routePathName', 'i18n:de-routePath')->shouldBeCalled();
 
         $this->routableSubscriber->handlePersist($event->reveal());
     }
@@ -360,6 +364,7 @@ public function testHandleReorder()
 
         $this->metadataFactory->getStructureMetadata('article', 'default')->willReturn($metadata->reveal());
         $this->propertyEncoder->localizedSystemName('routePath', 'de')->willReturn('i18n:de-routePath');
+        $this->propertyEncoder->localizedContentName('routePathName', 'de')->willReturn('i18n:de-routePathName');
 
         $children = [
             $this->prophesize(RoutablePageBehavior::class),
@@ -401,8 +406,11 @@ public function testHandleReorder()
         $children[2]->setRoutePath('/test-3')->shouldBeCalled();
 
         $nodes[0]->setProperty('i18n:de-routePath', '/test-1')->shouldBeCalled();
+        $nodes[0]->setProperty('i18n:de-routePathName', 'i18n:de-routePath')->shouldBeCalled();
         $nodes[1]->setProperty('i18n:de-routePath', '/test-2')->shouldBeCalled();
+        $nodes[1]->setProperty('i18n:de-routePathName', 'i18n:de-routePath')->shouldBeCalled();
         $nodes[2]->setProperty('i18n:de-routePath', '/test-3')->shouldBeCalled();
+        $nodes[2]->setProperty('i18n:de-routePathName', 'i18n:de-routePath')->shouldBeCalled();
 
         $this->routableSubscriber->handleReorder($event->reveal());
     }
-Original file line number
+Diff line change
@@ Expand Up / @@ -21,7 +21,6 @@ @@
     use Sulu\Component\Localization\Localization;
     use Symfony\Component\DependencyInjection\ContainerInterface;
     class Version202407111600 implements VersionInterface, ContainerAwareInterface
     {
         /**
@@ Expand Down @@